From: Peter Rosin <peda@lysator.liu.se>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Ahmad Byagowi <ahmadexp@gmail.com>,
Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/2] i2c: mux: Factor out channel node lookup
Date: Sat, 5 Sep 2026 07:46:36 +0200 [thread overview]
Message-ID: <apusvKc2PnSShaoI@gryt> (raw)
In-Reply-To: <apnRfWVAiXj1fRXs@ashevche-desk.local>
Den Thu, Sep 03, 2026 at 10:58:53PM +0300, skrev Andy Shevchenko:
> On Thu, Sep 03, 2026 at 12:40:55PM -0700, Ahmad Byagowi wrote:
> > Move the existing Device Tree channel-node lookup into a helper in
> > preparation for using generic firmware-node operations.
> >
> > This is a pure refactoring with no functional change.
>
> ...
>
> > +static struct device_node *
> > +i2c_mux_get_channel_node(struct i2c_mux_core *muxc, u32 chan_id)
> > +{
> > + struct device_node *dev_node;
> > + struct device_node *mux_node, *child;
>
> Now all three can be defined in a single line.
They could, but three is a crowd. So, if you bother to send an update,
please use one declaration per line instead to make future diffs
clearer.
Cheers,
Peter
next prev parent reply other threads:[~2026-09-05 5:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 19:40 [PATCH v9 0/2] i2c: mux: Propagate firmware nodes to channel adapters Ahmad Byagowi
2026-09-03 19:40 ` [PATCH v9 1/2] i2c: mux: Factor out channel node lookup Ahmad Byagowi
2026-09-03 19:58 ` Andy Shevchenko
2026-09-05 5:46 ` Peter Rosin [this message]
2026-09-05 7:48 ` Andy Shevchenko
2026-09-03 19:40 ` [PATCH v9 2/2] i2c: mux: Propagate firmware nodes to channel adapters Ahmad Byagowi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apusvKc2PnSShaoI@gryt \
--to=peda@lysator.liu.se \
--cc=ahmadexp@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox