Linux I2C development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Samuel Tirwa <samuel.tirwa@web.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: designware: use polling when IRQ resource is 0
Date: Tue, 3 Nov 2026 11:48:22 +0200	[thread overview]
Message-ID: <aumt5out9avKNuID@ashevche-desk.local> (raw)
In-Reply-To: <20261103090059.1759-1-samuel.tirwa@web.de>

On Tue, Nov 03, 2026 at 10:00:59AM +0100, Samuel Tirwa wrote:
> When an Intel LPSS I2C controller has no usable interrupt (firmware
> reports PCI INTx as not connected), intel-lpss passes 0 as the IRQ base,
> which leaves the child device with an IRQ resource whose start is 0.
> platform_get_irq_optional() then returns 0 instead of -ENXIO, so the
> DesignWare driver never enabled ACCESS_POLLING and request_irq(0, ...)
> failed.
> 
> Treat an IRQ number of 0 the same as 'no IRQ resource' and enable
> polling mode.

Slow down. You have made a mess in the mailing list: no email thread, no
versioning between the series of the same, no cover letter. Take your time to
become a familiar with the process first.

...

>  	irq = platform_get_irq_optional(pdev, 0);
> -	if (irq == -ENXIO)
> +	if (irq == -ENXIO || irq == 0)
>  		flags |= ACCESS_POLLING;
>  	else if (irq < 0)
>  		return irq;

NAK. irq==0 gives a warning and has not be a valid output from
platform_get_irq*().

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-11-03  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  9:00 [PATCH 2/2] i2c: designware: use polling when IRQ resource is 0 Samuel Tirwa
2026-11-03  9:48 ` Andy Shevchenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-11-03  8:59 [PATCH 1/2] mfd: intel-lpss: fall back to polling when no usable IRQ Samuel Tirwa
2026-11-03  8:59 ` [PATCH 2/2] i2c: designware: use polling when IRQ resource is 0 Samuel Tirwa
2026-11-03  8:57 [PATCH 1/2] mfd: intel-lpss: fall back to polling when no usable IRQ Samuel Tirwa
2026-11-03  8:57 ` [PATCH 2/2] i2c: designware: use polling when IRQ resource is 0 Samuel Tirwa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aumt5out9avKNuID@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=samuel.tirwa@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox