From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=194.117.254.33 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794143393; b=uNC4pD0gye0aQ3O8j7gGFR43yIuJg/1gXEVitPimV9YanojN3i5OXbCWWZtQsUBLaXUj jgMjOlDASne6YOKZAkHuDX42wRRptnNz/uWoWkulAhSFu1J0mTO77uoEjuKFqIue+5cnN pD41nslWGA2EQoHrbDYvADstjK8oKLjf9vqhngS34fB+F7a45hjhmsF4ubyhRIbW3jO18 dbVDabiCEWpndmnxFzPaYrO+5J3kcEaN1l1QX7SwD4oJE4l4pp8HWcfQMzIAwOvrDYeSP iLQFawk9Q4Lf/lL6wP3zwjri+Vc5Hl6qW+FTPTioTNNWe3y7wHwM1s7R8PjwraNVr6A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794143393; h=DMARC-Filter:DKIM-Signature:Received:Received:X-UD-Smtp-Session:Date: From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=I3PC3A4NSdlRK/+gF9U8MaN8hg4LHTavvcrEyCuAnbY=; b=QhH0Lqw0QZEN1zBH/Y7E31pzJVBbODg+CSogqDZDg/FDE4JAWtFLdUaHrxcp8U65XlNs hMkgQFNT+GcDhYTa1fzBVOyA1eTtHA8q0sxD4JZBdFNwhSnwxVae/q/e1qu+Dv/DLEqG+ m6FvoobpJY4fPWFTX+iNc0mPmReunzXJmux2kQLunlvGv3/LsPzKW5mD9m61HTeA5uZaD tEVyi6uwl7EFuOsgPyTONDEMupepdtUI4V9xNV0b9PymVD2mNab64INVNwXfN/hwAK5AK x+rUbUXzGjHYQV62ncjqnjpe6Rj0n9YIinfMs8MtwXEqbPNpt9573TMN4qq+3wGTfag== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=X5IE5Q7S; arc=none smtp.remote-ip=194.117.254.33 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EF1C606A31C for ; Sun, 8 Nov 2026 13:09:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5EF1C606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sang-engineering.com header.i=@sang-engineering.com header.a=rsa-sha256 header.s=k1 header.b=X5IE5Q7S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=I3PC 3A4NSdlRK/+gF9U8MaN8hg4LHTavvcrEyCuAnbY=; b=X5IE5Q7SDf4mVNPwYZ7c P6TCEfU8iZTxGN4lAtmcDnQz141fZfgPCT47u3NVI9z/FaR7nDm/cL0m7PhwBEb8 cSoj7mWwyYRIR0nYlQaLejFRT//0HuJUH/xZLaWaozzyY4A5edYFKjCGyHz5lcFj XRigLSvs/irffktFQl2cldL1q3OYQjieOWf3C1nX9mCaazz1mI/v1sf89eFr4P5D so1EW1Ccdj+rpaptUyTxfHbupSV0O6XJy51I+1Xxes/69T8ZACUc8SF8OvtpPbFO g4csC8lnVqsWjNbn8Dj9ecqAT0LPepRU+SLagzyYQeXvbFCiLr37foVy0WyZA/D4 tA== Received: (qmail 2848243 invoked from network); 8 Nov 2026 14:09:38 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 8 Nov 2026 14:09:38 +0100 X-UD-Smtp-Session: l3s3148p1@ktK5jsNfBoAvQDC3 Date: Sun, 8 Nov 2026 14:09:37 +0100 From: Wolfram Sang To: Brigham Campbell Cc: Jean Delvare , linux-i2c@vger.kernel.org, Gero =?utf-8?Q?Schw=C3=A4ricke?= Subject: Re: [PATCH v5 1/2] i2c-tools: Allow passing device file paths Message-ID: References: <20260722-accept-device-path-v5-0-9c0bf9b4da26@brighamcampbell.com> <20260722-accept-device-path-v5-1-9c0bf9b4da26@brighamcampbell.com> X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CXtI1Kbqkw4khBPc" Content-Disposition: inline In-Reply-To: <20260722-accept-device-path-v5-1-9c0bf9b4da26@brighamcampbell.com> --CXtI1Kbqkw4khBPc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Brigham, finally! Thanks to a long train travel :) On Wed, Jul 22, 2026 at 02:52:40AM -0600, Brigham Campbell wrote: > Make i2c-tools binaries accept a device file path or symlink directly. > This is useful, for example, for use with stable symlinks generated by > udev. >=20 > In the case of conflict, the bus parameter is parsed with the following > precedence in order to maintain backwards compatibility: >=20 > number -> name -> device path >=20 > Suggested-by: Gero Schw=C3=A4ricke > Signed-off-by: Brigham Campbell Yes, I like how this turned out in the end. I think the code is easy to understand. It seems to work well. It took a little time to find one corner case in need to be dealt with ;) But it is simple enough... > + i2cbus_ul =3D strtoul(i2cbus_arg, &end, 0); > + if (!*end && *i2cbus_arg) { > + if (i2cbus_ul > 0xFFFFF) { > + fprintf(stderr, "Error: I2C bus out of range!\n"); > + return -2; This fails if you use a name/path like "1111111111111". A diff like this makes it work: diff --git a/tools/i2cbusses.c b/tools/i2cbusses.c index 40d863f..47ebffa 100644 --- a/tools/i2cbusses.c +++ b/tools/i2cbusses.c @@ -436,12 +436,7 @@ int open_i2c_dev(char *i2cbus_arg, char **filename, si= ze_t size, int quiet) char *end; =20 i2cbus_ul =3D strtoul(i2cbus_arg, &end, 0); - if (!*end && *i2cbus_arg) { - if (i2cbus_ul > 0xFFFFF) { - fprintf(stderr, "Error: I2C bus out of range!\n"); - return -2; - } - + if (!*end && *i2cbus_arg && i2cbus_ul < 0x100000) { return open_i2c_dev_by_nr(i2cbus_ul, *filename, size, quiet); } =20 That should do it, or? > + fprintf(stderr, "Error: Couldn't interpret `%s' as a bus number, " > + "name, or device file path!\n", i2cbus_arg); > + I think this error message does its job very well. In my book, no need to make it more fine-grained. The rest (including patch 2) looks also good to me. Thank you and happy hacking, Wolfram --CXtI1Kbqkw4khBPc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmrwdI0ACgkQFA3kzBSg KbYyTA/9E7PPHrtWerNjET7k45VtzhhQTZI/FIEhlUkjY7SFDCPGmvESXnaSFosd AndQjaC3dqWK9ksJq+3vdFuFCeW3YYnzyCTgwQRLySZpJs9irc99l5aKG+xr9upN /ZsaYO3fGC28mssA8DbH4GcyOBe93v6RIM5KG9ic4YPROHqRzhNHSR5RPMwldMbp fGg6Xs3+gE3WVuFKHs+gkpoKVOMKnZTWXXYkIsOqQum8LBaZFe1CfQs3Hh+jKMlL DTvBJCrI8HoTIkiiWy6lw7C/Msm6I0YCK5eLeydMIsdLYEwtXtm+datB7Hnp0E4s R3lmz2qc4JtflddWSPgiSvGLZT5i+AP/RLcKgqSGVypp58/3zJ7BFDw6vOevWkbX joxgHw+01No7ppzNjxF2xG24nOz54TX9escI/i2Ve248HTB4E/hml4D0lhiqGKi0 ohCe6VFWXyDQQ33zimgIquS1iWZjHInq79/kATgGdHRpOK9UsNwDJD+sQgGLxmz7 juKiXEx4EBe1JgswqdNfYZMhamJd5HUst5OVTH56PWIrUmS8kMaKk8xS8yVmSHwO 5BUgS82ZFer3OVQgQAo7Fsz0bSfdYCdCjmHzlVWr/PyaYpTnc/Kwk0KmW7Ojyaxq FQXgvyD/Npj4dNuKLcNzAqFrAK25klZfPjKlwlAHkfShpHYuTXM= =/8OC -----END PGP SIGNATURE----- --CXtI1Kbqkw4khBPc--