Linux I2C development
 help / color / mirror / Atom feed
From: Alain Volmat <alain.volmat@foss.st.com>
To: Joshua Crofts <crofts@kernel.org>
Cc: Michal Simek <michal.simek@amd.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Oleksij Rempel <o.rempel@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Chris Brandt <chris.brandt@renesas.com>,
	Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<imx@lists.linux.dev>, <linux-renesas-soc@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>
Subject: Re: [PATCH 5/6] i2c: stm32f7: remove redundant pm_runtime_dont_use_autosuspend() calls
Date: Tue, 17 Nov 2026 10:03:17 +0100	[thread overview]
Message-ID: <avwYVXluZuM4vteb@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20261109-i2c-remove-dont-use-autosuspend-v1-5-49a08b8daf36@kernel.org>

Hi,

On Mon, Nov 09, 2026 at 09:50:06PM +0100, Joshua Crofts wrote:
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
> ---
>  drivers/i2c/busses/i2c-stm32f7.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> index 2e1cc6a92b81..7904d888550c 100644
> --- a/drivers/i2c/busses/i2c-stm32f7.c
> +++ b/drivers/i2c/busses/i2c-stm32f7.c
> @@ -2325,7 +2325,6 @@ static int stm32f7_i2c_probe(struct platform_device *pdev)
>  	pm_runtime_put_noidle(i2c_dev->dev);
>  	pm_runtime_disable(i2c_dev->dev);
>  	pm_runtime_set_suspended(i2c_dev->dev);
> -	pm_runtime_dont_use_autosuspend(i2c_dev->dev);
>  
>  	if (i2c_dev->wakeup_src)
>  		dev_pm_clear_wake_irq(i2c_dev->dev);
> @@ -2367,7 +2366,6 @@ static void stm32f7_i2c_remove(struct platform_device *pdev)
>  	pm_runtime_put_noidle(i2c_dev->dev);
>  	pm_runtime_disable(i2c_dev->dev);
>  	pm_runtime_set_suspended(i2c_dev->dev);
> -	pm_runtime_dont_use_autosuspend(i2c_dev->dev);
>  
>  	if (i2c_dev->dma) {
>  		stm32_i2c_dma_free(i2c_dev->dma);
> 

Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>

Regards,
Alain
> -- 
> 2.56.0
> 

  reply	other threads:[~2026-11-17  9:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 20:50 [PATCH 0/6] i2c: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-11-09 20:50 ` [PATCH 1/6] i2c: cadence: remove redundant pm_runtime_dont_use_autosuspend() call Joshua Crofts
2026-11-09 20:50 ` [PATCH 2/6] i2c: img-scb: " Joshua Crofts
2026-11-09 20:50 ` [PATCH 3/6] i2c: imx: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-11-12  3:33   ` Frank Li
2026-11-09 20:50 ` [PATCH 4/6] i2c: riic: " Joshua Crofts
2026-11-10  7:57   ` Geert Uytterhoeven
2026-11-09 20:50 ` [PATCH 5/6] i2c: stm32f7: " Joshua Crofts
2026-11-17  9:03   ` Alain Volmat [this message]
2026-11-09 20:50 ` [PATCH 6/6] i2c: xiic: " Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avwYVXluZuM4vteb@gnbcxd0016.gnb.st.com \
    --to=alain.volmat@foss.st.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andi.shyti@kernel.org \
    --cc=chris.brandt@renesas.com \
    --cc=crofts@kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pierre-yves.mordret@foss.st.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox