Re: [PATCH] i2c: core: Call i2c_acpi_install_space_handler() before i2c_acpi_register_devices()

Mika Westerberg
2020-09-16T16:25:01Z

On Wed, Sep 16, 2020 at 05:56:54PM +0200, Hans de Goede wrote:
> Hi,
>
> On 9/9/20 12:32 PM, Hans de Goede wrote:
> > Some ACPI i2c-devices _STA method (which is used to detect if the device
> > is present) use autodetection code which probes which device is present
> > over i2c. This requires the I2C ACPI OpRegion handler to be registered
> > before we enumerate i2c-clients under the i2c-adapter.
> >
> > This fixes the i2c touchpad on the Lenovo ThinkBook 14-IIL and
> > ThinkBook 15 IIL not getting an i2c-client instantiated and thus not
> > working.
> >
> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1842039
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Ping? This fixes a serious problem (non working touchpad on various
> laptop models) and is a pretty straight-forward fix.
>
> Arguably it should even go to stable, but I'm not 100% sure about that
> because these sorta ACPI enumeration problems can sometimes by
> tricky. With that said in this case the fix does seem to be
> very straight forward and obviously correct.
>
> Mika, since this deals with the ACPI bits of the i2c-core can
> you review this one please?

Sure, looks like the right thing to do:

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>