From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFFB8C4167B for ; Tue, 13 Dec 2022 17:04:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235840AbiLMRDb (ORCPT ); Tue, 13 Dec 2022 12:03:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236302AbiLMRDC (ORCPT ); Tue, 13 Dec 2022 12:03:02 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D822D23E84 for ; Tue, 13 Dec 2022 09:01:14 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id cf42so5962804lfb.1 for ; Tue, 13 Dec 2022 09:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jZkkTB2vVZy5PFl0F2Kz7lMoOg/jX2YmaB9YFMk1IuU=; b=D36Tk+AKZRb1HHf7I8HW3An/qmmMmOAp8Mk/nupG82DmaofvnIRpwFofAP7Td9KVj3 zCzv/ARz/g+HYtxK2zxvNQ/qbP0peQUwYQYS4AkNNp0CjBPtKJ0b9tSVCYEqFZZruzqV vkYUP+XXW+5ZaNOXMGW/jlXPEThpPGINVj1gBzKa44Zyrtbfftazjuf9WcXZX64sBT8n bPb6NQb1oRtkduSfECFo85TQINt0fmnYk293oMXCDfCuLodRx69ynQoGeJB1jiIXhAyq neDeWbbr7VoFOq1Zgh21G/MfixoggnEZm9SWIP03O2ZOmexyImHVI+xpuke1IqC5n0pH U3KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jZkkTB2vVZy5PFl0F2Kz7lMoOg/jX2YmaB9YFMk1IuU=; b=57+uAx+sTn1dxtF3C65t0i0Gnp9IT8DH7zrNPvpp7UCzHyTCJ5w734xpDDXnsFLI6u ksereC1zw2ybOR5y12AQp0bb871/aRG0VedugnjjrbdBO6AR+HCtqwl5XET465PAI1iM GjzJIlUw3yuxydjKw14G8WN5k3FTPRtoJl7oPeY2QKEt5kHZCRvEvPlVo7h1A3Nk6Qbc IwYbrMbgyVbAPGGXcJFICndrboauyZmpIuDuscbPGROhcIr/g+ATXUZTHew2h24AZgBK U+LyVsIR22N0rk2Q6H6cYVBvMg4nTS43cCKNSSwEsOvh+N6NACZtAp25m/HJCnNFuKPZ XILg== X-Gm-Message-State: ANoB5pkhfNX3zGzUT8jsok0nj8zaGX3X66f5IWvW3YiQYWhIjrwqUNYV s7npV76qToq2ttL6Od0Cs+lLTQ== X-Google-Smtp-Source: AA0mqf6IsyLAWx1ryfbYJap6V4JVf8QaCT3d/ZARAIXp+XyrWMM+lZo/jDkWivsgVkvxm17PzWv42Q== X-Received: by 2002:a05:6512:2829:b0:4b6:f30c:c7a9 with SMTP id cf41-20020a056512282900b004b6f30cc7a9mr2249509lfb.1.1670950873219; Tue, 13 Dec 2022 09:01:13 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id z2-20020a056512370200b004b5766f48d8sm443208lfr.19.2022.12.13.09.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 09:01:12 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 18:01:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles Content-Language: en-US To: Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, andersson@kernel.org, agross@kernel.org Cc: marijn.suijten@somainline.org, Loic Poulain , Robert Foss , Rob Herring , Krzysztof Kozlowski , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221213115628.105149-1-konrad.dybcio@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 13.12.2022 17:58, Krzysztof Kozlowski wrote: > On 13/12/2022 12:56, Konrad Dybcio wrote: >> Almost every compatible string in the CCI driver is a duplicate. Adjust >> the bindings to include a common (first-soc-implementing-vX) compatible >> to remove the need to keep adding superfluous compatible strings. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 25 +++++++++++++------ >> 1 file changed, 17 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> index cf9f8fda595f..65cf7860a9a0 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml >> @@ -12,14 +12,23 @@ maintainers: >> >> properties: >> compatible: >> - enum: >> - - qcom,msm8226-cci >> - - qcom,msm8916-cci >> - - qcom,msm8974-cci >> - - qcom,msm8996-cci >> - - qcom,sdm845-cci >> - - qcom,sm8250-cci >> - - qcom,sm8450-cci >> + oneOf: > > Except missing test, Hm? I tested this locally with dt_binding_check and it passed.. how about also adding a comment to the driver, that > list of compatibles should not grow when not needed? Sure. Konrad > > Best regards, > Krzysztof >