From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jian Hu Subject: Re: [PATCH 0/2] i2c: meson: add support for Meson G12A SoC i2c controller Date: Thu, 29 Nov 2018 19:55:43 +0800 Message-ID: References: <1543489197-183181-1-git-send-email-jian.hu@amlogic.com> <8a6a204b28523e5a181f9e85dda18fade76a26a3.camel@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8a6a204b28523e5a181f9e85dda18fade76a26a3.camel@baylibre.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jerome Brunet , Neil Armstrong Cc: Kevin Hilman , Carlo Caione , Rob Herring , Martin Blumenstingl , Michael Turquette , Stephen Boyd , Wolfram Sang , Mark Rutland , Jianxin Pan , Hanjie Lin , linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 2018/11/29 19:02, Jerome Brunet wrote: > On Thu, 2018-11-29 at 18:59 +0800, Jian Hu wrote: >> 1)Add G12A SoC i2c compatible string in dt-bindings. >> 2)Add compatible and data for G12A I2C controller driver. >> >> Jian Hu (2): >> dt-bindings: i2c: meson: add Meson G12A SoC i2c compatible string >> i2c: meson: add support for Meson G12A SoC I2C controller > > Looks to me that the g12a is compatible with the axg. What is the point of > adding this new compatible string ? > I am okay if it is reasonable below in file arch/arm64/boot/dts/amlogic/meson-g12a.dtsi. I2c controller node just uses axg's compatible. i2c0: i2c@1f000 { compatible = "amlogic,meson-axg-i2c"; reg = <0x0 0x1f000 0x0 0x20>; interrupts = ; clocks = <&clkc CLKID_I2C>; #address-cells = <1>; #size-cells = <0>; status = "disabled"; }; If it is, I just submit the i2c controller node in meson-g12a.dtsi. >> >> Documentation/devicetree/bindings/i2c/i2c-meson.txt | 1 + >> drivers/i2c/busses/i2c-meson.c | 5 +++++ >> 2 files changed, 6 insertions(+) >> > > > . >