From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>
Cc: Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358
Date: Mon, 11 Sep 2023 12:43:06 +0200 [thread overview]
Message-ID: <b38632d8-6a9e-7368-3309-16edfca5d2be@linaro.org> (raw)
In-Reply-To: <CABqG17g8QOgU7cObe=4EMLbEC1PeZWxdPXt7zzFs35JGqpRbfg@mail.gmail.com>
On 11/09/2023 12:31, Naresh Solanki wrote:
>>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
>>> index 2d7bb998b0e9..fa73eadfdf7b 100644
>>> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
>>> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
>>> @@ -71,6 +71,23 @@ properties:
>>> description: A voltage regulator supplying power to the chip. On PCA9846
>>> the regulator supplies power to VDD2 (core logic) and optionally to VDD1.
>>>
>>> + maxim,isolate-stuck-channel:
>>> + type: boolean
>>> + description: Allows to use non faulty channels while a stuck channel is
>>> + isolated from the upstream bus. If not set all channels are isolated from
>>> + the upstream bus until the fault is cleared.
>>
>> Nothing improved here. As I said, please provide arguments or drop this
>> property.
> These features cannot be enabled by default because doing so may lead
> to unexpected behavior, such as bus disconnections(although that
> wasn't expected).
> These features should only be enabled after they have been validated
> by the board designer.
> Therefore, they cannot be enabled by default.
And what is needed to validate them for given board? IOW, what changes
in hardware design that it can or cannot be used?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-11 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 10:15 [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358 Naresh Solanki
2023-08-31 10:15 ` [PATCH v2 2/2] i2c: muxes: pca954x: Enable features on MAX7357/MAX7358 Naresh Solanki
2023-08-31 12:03 ` [PATCH v2 1/2] dt-bindings: i2c: Add custom properties for MAX7357/MAX7358 Krzysztof Kozlowski
2023-09-11 10:31 ` Naresh Solanki
2023-09-11 10:43 ` Krzysztof Kozlowski [this message]
2023-09-11 11:39 ` Naresh Solanki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b38632d8-6a9e-7368-3309-16edfca5d2be@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=patrick.rudolph@9elements.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox