From: Ruan Jinjie <ruanjinjie@huawei.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: "Yann Sionneau" <yann@sionneau.net>,
"Leo Li" <leoyang.li@nxp.com>,
"Codrin Ciubotariu" <codrin.ciubotariu@microchip.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>, "Wolfram Sang" <wsa@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux@armlinux.org.uk, linux-gpio@vger.kernel.org,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next v2] I2C: Fix return value check for devm_pinctrl_get()
Date: Fri, 18 Aug 2023 15:27:26 +0800 [thread overview]
Message-ID: <b423658a-e129-4aa5-3f7a-3bc477d4630b@huawei.com> (raw)
In-Reply-To: <CACRpkdbikkc+oepJqZsUz27MTOHLMp-QQPdgRZ7XQGTG-=aAKA@mail.gmail.com>
On 2023/8/18 15:18, Linus Walleij wrote:
> On Fri, Aug 18, 2023 at 7:33 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
>> NULL is returned on purpose. When PINCTRL is disabled NULL becomes a
>> valid pinctrl cookie which can be passed to the other stub functions.
>> With this drivers using pinctrl can get through their probe function
>> without an error when PINCTRL is disabled.
>>
>> The same approach is taken by the clk and regulator API.
>>
>> It is correct to test the return value of devm_pinctrl_get() with
>> IS_ERR(), only the commit message of these patches is a bit inaccurate.
>
> Sascha is spot on, maybe copyedit some of the above
> into the commit message and resend?
OK! I'll resend it.
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2023-08-18 7:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 2:20 [PATCH -next v2] I2C: Fix return value check for devm_pinctrl_get() Ruan Jinjie
2023-08-17 4:38 ` Oleksij Rempel
2023-08-17 6:58 ` Linus Walleij
2023-08-17 16:01 ` Nicolas Ferre
2023-08-17 17:30 ` Leo Li
2023-08-17 23:07 ` Yann Sionneau
2023-08-18 1:53 ` Ruan Jinjie
2023-08-18 5:32 ` Sascha Hauer
2023-08-18 7:18 ` Linus Walleij
2023-08-18 7:27 ` Ruan Jinjie [this message]
2023-08-18 2:47 ` Ruan Jinjie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b423658a-e129-4aa5-3f7a-3bc477d4630b@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=codrin.ciubotariu@microchip.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=nicolas.ferre@microchip.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
--cc=yann@sionneau.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox