From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aahil Awatramani <aahila@google.com>,
David Dillow <dillow@google.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: designware: allow fine tuning tuning waveform from device tree
Date: Thu, 1 Feb 2024 08:34:49 +0100 [thread overview]
Message-ID: <b4b2ec92-b0ad-4702-94a6-ac128181d801@linaro.org> (raw)
In-Reply-To: <20240201044623.374389-2-aahila@google.com>
On 01/02/2024 05:46, Aahil Awatramani wrote:
>
> +static void i2c_parse_cnt(struct device *dev, char *prop_name, u16 *cnt)
> +{
> + u32 tmp_cnt;
> + int ret;
> +
> + ret = device_property_read_u32(dev, prop_name, &tmp_cnt);
> + if (ret)
> + return;
> + *cnt = tmp_cnt;
> +}
> +
> static int dw_i2c_of_configure(struct platform_device *pdev)
> {
> struct dw_i2c_dev *dev = platform_get_drvdata(pdev);
> @@ -146,6 +157,15 @@ static int dw_i2c_of_configure(struct platform_device *pdev)
> break;
> }
>
> + i2c_parse_cnt(&pdev->dev, "i2c-scl-ss-hcnt", &dev->ss_hcnt);
Please post your DTS and post results of testing it against bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-01 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 4:46 [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree Aahil Awatramani
2024-02-01 4:46 ` [PATCH 2/2] " Aahil Awatramani
2024-02-01 7:34 ` Krzysztof Kozlowski [this message]
2024-02-01 7:33 ` [PATCH 1/2] dt-bindings: " Krzysztof Kozlowski
2024-02-01 11:46 ` Andy Shevchenko
2024-02-09 21:05 ` Aahil Awatramani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4b2ec92-b0ad-4702-94a6-ac128181d801@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aahila@google.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dillow@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox