Re: [PATCH 02/13] regmap: add A2B support

Alvin Šipraga
2024-05-21T06:27:24Z

On Fri, May 17, 2024 at 03:42:31PM GMT, Mark Brown wrote:
> On Fri, May 17, 2024 at 02:58:00PM +0200, Alvin Šipraga wrote:
>
> > +static int regmap_a2b_write(void *context, const void *data, size_t count)
> > +{
>
> > + for (i = 0; i < count - 1; i++) {
> > + ret = bus->ops->write(bus, node, reg + i, d[i + 1]);
> > + if (ret)
> > + return ret;
> > + }
>
> Just force single_read and single_write

Ah OK, i.e. return -EINVAL if (!config->use_single_read ||
!config->use_single_write) in the init functions below?

> (looks like you'll need to add
> the hook for the bus there).

I am not sure what you mean by this, can you elaborate?

>
> > +struct regmap *__devm_regmap_init_a2b_node(struct a2b_node *node,
> > + const struct regmap_config *config,
> > + struct lock_class_key *lock_key,
> > + const char *lock_name)
> > +{
> > + return __devm_regmap_init(&node->dev, &regmap_a2b, node, config,
> > + lock_key, lock_name);
> > +}
> > +EXPORT_SYMBOL_GPL(__devm_regmap_init_a2b_node);
>
> Should there be validation of val_bits?

Yes, I can and should enforce reg/val bits to always be 8.