Re: [PATCH 01/13] a2b: add A2B driver core

Markus Elfring
2024-05-21T07:34:13Z

>> …
>>> +++ b/drivers/a2b/a2b.c
>>> @@ -0,0 +1,1252 @@
>> …
>>> +static int a2b_bus_of_add_node(struct a2b_bus *bus, struct device_node *np,
>>> + unsigned int addr)
>>> +{
>> …
>>> + node = kzalloc(sizeof(*node), GFP_KERNEL);
>>> + if (IS_ERR(node))
>>> + return -ENOMEM;
>>
>> Please improve the distinction for checks according to the handling of error/null pointers.
>
> Right, I think it returns NULL on error.

Do you see possibilities to reduce “confusion” about the properties of such a programming interface
any further?
https://elixir.bootlin.com/linux/v6.9.1/A/ident/kzalloc

Regards,
Markus