From: Krzysztof Kozlowski <krzk@kernel.org>
To: Troy Mitchell <troymitchell988@gmail.com>,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT K1 SoC
Date: Fri, 18 Oct 2024 10:39:23 +0200 [thread overview]
Message-ID: <b565658d-391b-4b39-92d1-0413fff00635@kernel.org> (raw)
In-Reply-To: <6545eabc-1956-4e55-be99-e0b35650a773@gmail.com>
On 18/10/2024 10:33, Troy Mitchell wrote:
>
> On 2024/10/18 14:05, Krzysztof Kozlowski wrote:
>> On 18/10/2024 07:17, Troy Mitchell wrote:
>>>
>>> On 2024/10/15 16:08, Krzysztof Kozlowski wrote:
>>>>> + disable_irq(i2c->irq);
>>>> Why?
>>>
>>> I just want to turn on the interrupt when the transmission starts,
>>> and turn off the interrupt after the transmission ends.
>>> The interrupt shutdown in the probe is a starting point
>>> before the transmission starts.
>>>
>>> Is this reasonable? If not, I will modify it.
>>
>> You cut so much context I don't know what this refers to. I will leave
>> it to I2C maintainers, but toggling interrupt on probe is weird.
>> Toggling it for every transfer as well.
>>
>> Best regards,
>> Krzysztof
>>
>
> In addition to this problem, should I send v2 after
> I fix all the errors pointed out in the email,
> or should I wait for I2C maintainers?
I think you got reviews from them, so I would go ahead with v2.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-18 8:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 7:51 [PATCH v1 0/2] riscv: spacemit: add i2c support to K1 SoC Troy Mitchell
2024-10-15 7:51 ` [PATCH v1 1/2] dt-bindings: i2c: spacemit: add support for " Troy Mitchell
2024-10-15 8:02 ` Krzysztof Kozlowski
2024-10-15 16:47 ` Conor Dooley
2024-10-16 2:45 ` Troy Mitchell
2024-10-16 7:44 ` Krzysztof Kozlowski
2024-10-15 9:22 ` Rob Herring (Arm)
2024-10-15 7:51 ` [PATCH v1 2/2] i2c: spacemit: add support for SpacemiT " Troy Mitchell
2024-10-15 8:08 ` Krzysztof Kozlowski
2024-10-15 9:21 ` Wolfram Sang
2024-10-18 5:17 ` Troy Mitchell
2024-10-18 6:05 ` Krzysztof Kozlowski
2024-10-18 8:33 ` Troy Mitchell
2024-10-18 8:39 ` Krzysztof Kozlowski [this message]
2024-10-15 9:17 ` Wolfram Sang
2024-10-16 2:26 ` Troy Mitchell
2024-10-16 7:06 ` Wolfram Sang
2024-10-16 9:39 ` Uwe Kleine-König
2024-10-21 7:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b565658d-391b-4b39-92d1-0413fff00635@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=troymitchell988@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).