Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue

Ray Jui
2023-06-26T17:20:08Z

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On 6/26/2023 10:05 AM, YE Chengfeng wrote:
>> This fix looks good to me. Thanks. Just curious, did you actually see a
>> race condition issue as a result of this, or the fix is done completely
>> based on the analysis of the code?
>
> Thanks for the reply!
>
> This bug is detected by a static analysis tool built by me, I just notice I should
> mention this in the commit message and sorry for not have made it clear. I noticed
> lockdep occasionally reported such similar deadlocks in other place thus built the
> static tool to locate such bugs.
>
> Just feel free to let me know if anything in the patch should be improved.
>
> Best Regards,
> Chengfeng

This sounds good. Thanks again, Chengfeng!

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4194 bytes --]