Re: [PATCH v2 3/3] platform/x86: Use i2c adapter name to fix build errors

Nirujogi, Pratap
2025-06-04T02:26:19Z

On 6/3/2025 6:49 PM, Randy Dunlap wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On 6/3/25 2:40 PM, Pratap Nirujogi wrote:
>> Use adapater->name inplace of adapter->owner->name to fix
>> build issues when CONFIG_MODULES is not defined.
>>
>> Fixes: 90b85567e457 ("platform/x86: Add AMD ISP platform config for OV05C10")
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Link: https://lore.kernel.org/all/04577a46-9add-420c-b181-29bad582026d@infradead.org
>> Signed-off-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks.
>
Thanks Randy!

>
>> ---
>> drivers/platform/x86/amd/amd_isp4.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/amd_isp4.c b/drivers/platform/x86/amd/amd_isp4.c
>> index 0cc01441bcbb..9f291aeb35f1 100644
>> --- a/drivers/platform/x86/amd/amd_isp4.c
>> +++ b/drivers/platform/x86/amd/amd_isp4.c
>> @@ -11,6 +11,7 @@
>> #include <linux/mutex.h>
>> #include <linux/platform_device.h>
>> #include <linux/property.h>
>> +#include <linux/soc/amd/isp4_misc.h>
>> #include <linux/string.h>
>> #include <linux/types.h>
>> #include <linux/units.h>
>> @@ -151,7 +152,7 @@ MODULE_DEVICE_TABLE(acpi, amdisp_sensor_ids);
>>
>> static inline bool is_isp_i2c_adapter(struct i2c_adapter *adap)
>> {
>> - return !strcmp(adap->owner->name, "i2c_designware_amdisp");
>> + return !strcmp(adap->name, AMDISP_I2C_ADAP_NAME);
>> }
>>
>> static void instantiate_isp_i2c_client(struct amdisp_platform *isp4_platform,
>
> --
> ~Randy