From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Simon Horman <horms@verge.net.au>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 2/2] i2c: designware: Add support for a bus clock
Date: Wed, 18 Jul 2018 15:52:20 +0300 [thread overview]
Message-ID: <b70d78516e765b3a6587323cffb6066e9363cd48.camel@linux.intel.com> (raw)
In-Reply-To: <CAMuHMdWJkwJ5+DDqbaWH-cMhRQynWCxb4MbFtpejqi1HhUBHTQ@mail.gmail.com>
On Wed, 2018-07-18 at 13:06 +0200, Geert Uytterhoeven wrote:
> On Wed, Jul 18, 2018 at 11:14 AM Simon Horman <horms@verge.net.au>
> wrote:
> > if (IS_ERR(dev->buslck) && PTR_ERR(dev->busclk) != -ENOENT)
> > return PTR_ERR(dev->busclk);
> >
> > ...
>
> As this is a commonly-used construct, perhaps it would be good to
> introduce
> clk_get_optional() (cfr. gpiod_get_optional()) and
> devm_clk_get_optional(),
> which would return NULL instead of -ENOENT?
> Then it becomes a simple check for IS_ERR() in the driver.
I'm puzzled why CCF still lack of such API.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-07-18 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 8:59 [PATCH 0/2] i2c: designware: Add support for a bus clock Phil Edworthy
2018-07-16 8:59 ` [PATCH 1/2] dt: snps,designware-i2c: Add clock bindings documentation Phil Edworthy
2018-07-20 16:19 ` Rob Herring
2018-07-16 8:59 ` [PATCH 2/2] i2c: designware: Add support for a bus clock Phil Edworthy
2018-07-17 12:07 ` Simon Horman
2018-07-17 12:23 ` Andy Shevchenko
2018-07-17 12:42 ` Phil Edworthy
2018-07-17 13:01 ` Geert Uytterhoeven
2018-07-17 13:12 ` Phil Edworthy
2018-07-17 14:18 ` Andy Shevchenko
2018-07-17 14:40 ` Phil Edworthy
2018-07-17 14:47 ` Andy Shevchenko
2018-07-17 14:57 ` Phil Edworthy
2018-07-18 9:14 ` Simon Horman
2018-07-18 9:21 ` Phil Edworthy
2018-07-19 7:42 ` Simon Horman
2018-07-18 11:06 ` Geert Uytterhoeven
2018-07-18 12:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70d78516e765b3a6587323cffb6066e9363cd48.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).