From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C2FC433F5 for ; Fri, 4 Mar 2022 11:46:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbiCDLr1 (ORCPT ); Fri, 4 Mar 2022 06:47:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229574AbiCDLr0 (ORCPT ); Fri, 4 Mar 2022 06:47:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2FE4B1680AB for ; Fri, 4 Mar 2022 03:46:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646394395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObWgVceW+qaF094L/LrZKP/18J1+19p9ZMszIe3Wv+8=; b=G7XadozemUxxE70qY5UhpIa0440czo1eK7pUrrGn4Wvz8Pd3xtI3wAdPWZdoKPRlUUubmN uH1iMTcYsXJB4VLwB7RlDRA6EnAgOiKDVsv/FUzOXGVhEywKQCETkpsUIApXv2XkWLd4j9 s1039YHuWGFWr5bf8kjiAb/XaNZrSU4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-5gAvIYRgPFKnRiLulAFCoQ-1; Fri, 04 Mar 2022 06:46:34 -0500 X-MC-Unique: 5gAvIYRgPFKnRiLulAFCoQ-1 Received: by mail-ed1-f69.google.com with SMTP id j10-20020a05640211ca00b004090fd8a936so4447775edw.23 for ; Fri, 04 Mar 2022 03:46:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ObWgVceW+qaF094L/LrZKP/18J1+19p9ZMszIe3Wv+8=; b=pjnuPOjSwY5RtHaX57zwtV2hFPT/TC3YlLJIOJ6FEumjl1F+x+RNohB5n0KPINPlpz F7iDAePtNOHi6ShmmcWg8vGnkqBgWDkSOjrcMWEj4TWQ2U6wR7F/sCsoA9TOduCsIAJM ukvN/QzAkNAnr3f5ZUztjLI+LUMHn101hx9uArxt+WSFUeB5Ihn1NqshLMNxrzjng937 ygKF+vNaXzmflnXJyECdKMt5eH/9DLoa69eszSLi/nS2u7Ww73cZagUBtlsEUzm3x2sW 4VFD9RnoDNaukL3FIa16Hk2/yT+YX13Jbxv5gN+OHJDNMfL90/MB5gaMsADbvDL2ZIHg fw+g== X-Gm-Message-State: AOAM5311gRSHsT76vUuXGk7OZS5q6mSK0k1tKV6pqtbzAJkadYcE5Fox V5ozRzcD7+hC1wNHbjPNHI0/V3Mad3sFmnl93kSUXoHcAZfv9uD6rRil3NlhRcTxXigWjFTj8WF +pp8NMxWJzhGq1uDKDep9 X-Received: by 2002:a17:906:6a11:b0:6d7:76cc:12f6 with SMTP id qw17-20020a1709066a1100b006d776cc12f6mr11919989ejc.456.1646394392784; Fri, 04 Mar 2022 03:46:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEh+dczpDjjT+p5sWJXuZzWsG2sUcVmVuREh4s52hWozp5u84TEs+jg3XtYOLD63lQEHPEdA== X-Received: by 2002:a17:906:6a11:b0:6d7:76cc:12f6 with SMTP id qw17-20020a1709066a1100b006d776cc12f6mr11919979ejc.456.1646394392597; Fri, 04 Mar 2022 03:46:32 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id k17-20020a1709062a5100b006d5c69301e4sm1677893eje.202.2022.03.04.03.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Mar 2022 03:46:32 -0800 (PST) Message-ID: Date: Fri, 4 Mar 2022 12:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH -next] i2c: designware: Mark dw_i2c_plat_{suspend,resume}() as __maybe_unused Content-Language: en-US To: Nathan Chancellor , Wolfram Sang , Jarkko Nikula Cc: Andy Shevchenko , Mika Westerberg , Jan Dabros , linux-i2c@vger.kernel.org, patches@lists.linux.dev References: <20220303191713.2402461-1-nathan@kernel.org> From: Hans de Goede In-Reply-To: <20220303191713.2402461-1-nathan@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 3/3/22 20:17, Nathan Chancellor wrote: > When CONFIG_PM is set but CONFIG_PM_SLEEP is not, two compiler warnings > appear: > > drivers/i2c/busses/i2c-designware-platdrv.c:444:12: error: unused function 'dw_i2c_plat_suspend' [-Werror,-Wunused-function] > static int dw_i2c_plat_suspend(struct device *dev) > ^ > drivers/i2c/busses/i2c-designware-platdrv.c:465:12: error: unused function 'dw_i2c_plat_resume' [-Werror,-Wunused-function] > static int dw_i2c_plat_resume(struct device *dev) > ^ > 2 errors generated. > > These functions are only used in SET_LATE_SYSTEM_SLEEP_PM_OPS(), which > is defined as empty when CONFIG_PM_SLEEP is not defined. Mark the > functions as __maybe_unused to make it clear that these functions might > be unused in this configuration. > > Fixes: c57813b8b288 ("i2c: designware: Lock the adapter while setting the suspended flag") > Signed-off-by: Nathan Chancellor Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c > index 116a297d1f6b..70ade5306e45 100644 > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > @@ -441,7 +441,7 @@ static int dw_i2c_plat_runtime_suspend(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_suspend(struct device *dev) > +static int __maybe_unused dw_i2c_plat_suspend(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > @@ -462,7 +462,7 @@ static int dw_i2c_plat_runtime_resume(struct device *dev) > return 0; > } > > -static int dw_i2c_plat_resume(struct device *dev) > +static int __maybe_unused dw_i2c_plat_resume(struct device *dev) > { > struct dw_i2c_dev *i_dev = dev_get_drvdata(dev); > > > base-commit: 1d366c2f9df8279df2adbb60471f86fc40a1c39e