From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Michael Wu <michael.wu@vatics.com>,
Tian Ye <tianye@sugon.com>
Subject: Re: [PATCH v2 12/12] i2c: designware: Add comment to custom register value constants
Date: Thu, 3 Nov 2022 10:48:35 +0200 [thread overview]
Message-ID: <ba33ef90-fe7b-7553-19ac-d89835ed3583@linux.intel.com> (raw)
In-Reply-To: <Y2KAteiXN87LZ72v@smile.fi.intel.com>
On 11/2/22 16:37, Andy Shevchenko wrote:
> On Wed, Nov 02, 2022 at 03:11:25PM +0200, Jarkko Nikula wrote:
>> DW_IC_COMP_VERSION register contains the ASCII representation of the
>> Synopsys component version followed by '*'. Here 0x3131312A == "111*"
>> means version 1.11 is required for DW_IC_SDA_HOLD register availability.
>
> The '*' means "any letter, starting from a", so I would put it as 1.11a.
> And perhaps explain that the fourth character meaning.
> This will be in align with their datasheets.
>
Sadly a few Synopsys datasheets I have don't much explain this or refer
to AMBA release notes so I don't want to carve things I don't know in stone.
Jarkko
next prev parent reply other threads:[~2022-11-03 8:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 13:11 [PATCH v2 00/12] i2c: designware: Slave fixes and generic cleanups Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 01/12] i2c: designware: Fix slave state machine for sequential reads Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 02/12] i2c: designware: Empty receive FIFO in slave interrupt handler Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 03/12] i2c: designware: Define software status flags with BIT() Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 04/12] i2c: designware: Remove needless initializations from i2c_dw_reg_slave() Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 05/12] i2c: designware: Remove unused completion code from i2c-designware-slave Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 06/12] i2c: designware: Simplify slave interrupt handler nesting Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 07/12] i2c: designware: Do not process interrupt when device is suspended Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 08/12] i2c: designware: Move debug print in i2c_dw_isr() Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 09/12] i2c: designware: Simplify master interrupt handler nesting Jarkko Nikula
2022-11-02 14:23 ` Andy Shevchenko
2022-11-02 13:11 ` [PATCH v2 10/12] i2c: designware: Remove common i2c_dw_disable_int() Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 11/12] i2c: designware: Align defines in i2c-designware-core.h Jarkko Nikula
2022-11-02 13:11 ` [PATCH v2 12/12] i2c: designware: Add comment to custom register value constants Jarkko Nikula
2022-11-02 14:37 ` Andy Shevchenko
2022-11-03 8:48 ` Jarkko Nikula [this message]
2022-11-02 14:28 ` [PATCH v2 00/12] i2c: designware: Slave fixes and generic cleanups Andy Shevchenko
2022-11-07 11:55 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba33ef90-fe7b-7553-19ac-d89835ed3583@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michael.wu@vatics.com \
--cc=mika.westerberg@linux.intel.com \
--cc=tianye@sugon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox