From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sverdlin, Alexander (Nokia - DE/Ulm)" Subject: Re: [PATCH 2/3] i2c-axxia: check for error conditions first Date: Tue, 11 Dec 2018 12:02:32 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: <2411DC2DB501F04FB6E5161538A5323A@eurprd07.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: "Adamski, Krzysztof (Nokia - PL/Wroclaw)" , Wolfram Sang Cc: "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Walleij , Guenter Roeck , Tobias Jordan , Peter Rosin List-Id: linux-i2c@vger.kernel.org SGkhDQoNCk9uIDEwLzEyLzIwMTggMTY6MDEsIEFkYW1za2ksIEtyenlzenRvZiAoTm9raWEgLSBQ TC9Xcm9jbGF3KSB3cm90ZToNCj4gSXQgd2FzIG9ic2VydmVkIHRoYXQgd2hlbiB1c2luZyBzZXFl bnRpb25hbCBtb2RlIGNvbnRyYXJ5IHRvIHRoZQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF5eXl5eXl5eXl5eDQo+IGRvY3VtZW50YXRpb24sIHRoZSBTUyBiaXQgKHdoaWNoIGlz IHN1cHBvc2VkIHRvIG9ubHkgYmUgc2V0IGlmDQo+IGF1dG9tYXRpYy9zZXF1ZW5jZSBjb21tYW5k IGNvbXBsZXRlZCBub3JtYWxseSksIGlzIHNvbWV0aW1lcyBzZXQNCj4gdG9nZXRoZXIgd2l0aCBO QSAoTkFLIGluIGFkZHJlc3MgcGhhc2UpIGNhdXNpbmcgdHJhbnNmZXIgdG8gZmFsc2VseSBiZQ0K PiBjb25zaWRlcmVkIHN1Y2Nlc3NmdWwuDQo+IA0KPiBNeSBhc3N1bXB0aW9uIGlzIHRoYXQgdGhp cyBkb2VzIG5vdCBoYXBwZW4gZHVyaW5nIG1hbnVhbCBtb2RlIHNpbmNlIHRoZQ0KPiBjb250cm9s bGVyIGlzIHN0b3BwaW5nIGl0cyB3b3JrIHRoZSBtb21lbnQgaXQgc2V0cyBOQS9ORCBiaXQgaW4g c3RhdHVzDQo+IHJlZ2lzdGVyLiBUaGlzIGlzIG5vdCB0aGUgY2FzZSBpbiBBdXRvbWF0aWMvU2Vx dWVudGlvbmFsIG1vZGUgd2hlcmUgaXQNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBeXl5eXl5eXl5eXl4NCj4gaXMgc3RpbGwgd29ya2luZyB0byBzZW5kIFNU T1AgY29uZGl0aW9uIGFuZCB0aGUgYWN0dWFsIHN0YXR1cyB3ZSBnZXQNCj4gZGVwZW5kcyBvbiB0 aGUgdGltZSB3aGVuIHRoZSBJU1IgaXMgcnVuLg0KPiANCj4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRo ZSBvcmRlciBvZiBjaGVja2luZyBzdGF0dXMgYml0cyBpbiBJU1IgLSBlcnJvcg0KPiBjb25kaXRp b25zIGFyZSBjaGVja2VkIGZpcnN0IGFuZCBvbmx5IGlmIG5vbmUgb2YgdGhlbSBvY2N1cnJlZCwg dGhlDQo+IHRyYW5zZmVyIG1heSBiZSBjb25zaWRlcmVkIHN1Y2Nlc3NmdWwuIFRoaXMgaXMgcmVx dWlyZWQgdG8gaW50cm9kdWNlDQo+IHVzaW5nIG9mIHNlcXVlbnRpb25hbCBtb2RlIGluIG5leHQg cGF0Y2guDQogICAgICAgICAgIF5eXl5eXl5eXl5eXg0Kc2VxdWVudGlhbA0KDQpSZXZpZXdlZC1i eTogQWxleGFuZGVyIFN2ZXJkbGluIDxhbGV4YW5kZXIuc3ZlcmRsaW5Abm9raWEuY29tPg0KDQo+ IFNpZ25lZC1vZmYtYnk6IEtyenlzenRvZiBBZGFtc2tpIDxrcnp5c3p0b2YuYWRhbXNraUBub2tp YS5jb20+DQo+IC0tLQ0KPiAgZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1heHhpYS5jIHwgMzIgKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNl cnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2ky Yy9idXNzZXMvaTJjLWF4eGlhLmMgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWF4eGlhLmMNCj4g aW5kZXggZDM3Y2FmNjk0ZmJmLi4zNTI1ODMyMWU4MWIgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv aTJjL2J1c3Nlcy9pMmMtYXh4aWEuYw0KPiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWF4 eGlhLmMNCj4gQEAgLTI5NiwyMiArMjk2LDcgQEAgc3RhdGljIGlycXJldHVybl90IGF4eGlhX2ky Y19pc3IoaW50IGlycSwgdm9pZCAqX2RldikNCj4gIAkJCWkyY19pbnRfZGlzYWJsZShpZGV2LCBN U1RfU1RBVFVTX1RGTCk7DQo+ICAJfQ0KPiAgDQo+IC0JaWYgKHN0YXR1cyAmIE1TVF9TVEFUVVNf U0NDKSB7DQo+IC0JCS8qIFN0b3AgY29tcGxldGVkICovDQo+IC0JCWkyY19pbnRfZGlzYWJsZShp ZGV2LCB+TVNUX1NUQVRVU19UU1MpOw0KPiAtCQljb21wbGV0ZSgmaWRldi0+bXNnX2NvbXBsZXRl KTsNCj4gLQl9IGVsc2UgaWYgKHN0YXR1cyAmIE1TVF9TVEFUVVNfU05TKSB7DQo+IC0JCS8qIFRy YW5zZmVyIGRvbmUgKi8NCj4gLQkJaTJjX2ludF9kaXNhYmxlKGlkZXYsIH5NU1RfU1RBVFVTX1RT Uyk7DQo+IC0JCWlmIChpMmNfbV9yZChpZGV2LT5tc2cpICYmIGlkZXYtPm1zZ194ZnJkIDwgaWRl di0+bXNnLT5sZW4pDQo+IC0JCQlheHhpYV9pMmNfZW1wdHlfcnhfZmlmbyhpZGV2KTsNCj4gLQkJ Y29tcGxldGUoJmlkZXYtPm1zZ19jb21wbGV0ZSk7DQo+IC0JfSBlbHNlIGlmIChzdGF0dXMgJiBN U1RfU1RBVFVTX1RTUykgew0KPiAtCQkvKiBUcmFuc2ZlciB0aW1lb3V0ICovDQo+IC0JCWlkZXYt Pm1zZ19lcnIgPSAtRVRJTUVET1VUOw0KPiAtCQlpMmNfaW50X2Rpc2FibGUoaWRldiwgfk1TVF9T VEFUVVNfVFNTKTsNCj4gLQkJY29tcGxldGUoJmlkZXYtPm1zZ19jb21wbGV0ZSk7DQo+IC0JfSBl bHNlIGlmICh1bmxpa2VseShzdGF0dXMgJiBNU1RfU1RBVFVTX0VSUikpIHsNCj4gKwlpZiAodW5s aWtlbHkoc3RhdHVzICYgTVNUX1NUQVRVU19FUlIpKSB7DQo+ICAJCS8qIFRyYW5zZmVyIGVycm9y ICovDQo+ICAJCWkyY19pbnRfZGlzYWJsZShpZGV2LCB+MCk7DQo+ICAJCWlmIChzdGF0dXMgJiBN U1RfU1RBVFVTX0FMKQ0KPiBAQCAtMzI4LDYgKzMxMywyMSBAQCBzdGF0aWMgaXJxcmV0dXJuX3Qg YXh4aWFfaTJjX2lzcihpbnQgaXJxLCB2b2lkICpfZGV2KQ0KPiAgCQkJcmVhZGwoaWRldi0+YmFz ZSArIE1TVF9UWF9CWVRFU19YRlJEKSwNCj4gIAkJCXJlYWRsKGlkZXYtPmJhc2UgKyBNU1RfVFhf WEZFUikpOw0KPiAgCQljb21wbGV0ZSgmaWRldi0+bXNnX2NvbXBsZXRlKTsNCj4gKwl9IGVsc2Ug aWYgKHN0YXR1cyAmIE1TVF9TVEFUVVNfU0NDKSB7DQo+ICsJCS8qIFN0b3AgY29tcGxldGVkICov DQo+ICsJCWkyY19pbnRfZGlzYWJsZShpZGV2LCB+TVNUX1NUQVRVU19UU1MpOw0KPiArCQljb21w bGV0ZSgmaWRldi0+bXNnX2NvbXBsZXRlKTsNCj4gKwl9IGVsc2UgaWYgKHN0YXR1cyAmIE1TVF9T VEFUVVNfU05TKSB7DQo+ICsJCS8qIFRyYW5zZmVyIGRvbmUgKi8NCj4gKwkJaTJjX2ludF9kaXNh YmxlKGlkZXYsIH5NU1RfU1RBVFVTX1RTUyk7DQo+ICsJCWlmIChpMmNfbV9yZChpZGV2LT5tc2cp ICYmIGlkZXYtPm1zZ194ZnJkIDwgaWRldi0+bXNnLT5sZW4pDQo+ICsJCQlheHhpYV9pMmNfZW1w dHlfcnhfZmlmbyhpZGV2KTsNCj4gKwkJY29tcGxldGUoJmlkZXYtPm1zZ19jb21wbGV0ZSk7DQo+ ICsJfSBlbHNlIGlmIChzdGF0dXMgJiBNU1RfU1RBVFVTX1RTUykgew0KPiArCQkvKiBUcmFuc2Zl ciB0aW1lb3V0ICovDQo+ICsJCWlkZXYtPm1zZ19lcnIgPSAtRVRJTUVET1VUOw0KPiArCQlpMmNf aW50X2Rpc2FibGUoaWRldiwgfk1TVF9TVEFUVVNfVFNTKTsNCj4gKwkJY29tcGxldGUoJmlkZXYt Pm1zZ19jb21wbGV0ZSk7DQo+ICAJfQ0KPiAgDQo+ICBvdXQ6DQo+IA0KDQotLSANCkJlc3QgcmVn YXJkcywNCkFsZXhhbmRlciBTdmVyZGxpbi4NCg==