From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading Date: Tue, 18 Oct 2016 12:25:42 +0200 Message-ID: References: <20161005155112.13774-1-hdegoede@redhat.com> <20161005155112.13774-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759389AbcJRKZt (ORCPT ); Tue, 18 Oct 2016 06:25:49 -0400 In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Chen-Yu Tsai Cc: Lee Jones , Sebastian Reichel , Dennis Gilmore , Maxime Ripard , "open list:THERMAL" , linux-arm-kernel , Wolfram Sang , linux-i2c@vger.kernel.org Hi, On 18-10-16 07:25, Chen-Yu Tsai wrote: > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede wrote: >> The i2c subsys does not load modules by compatible, only by >> i2c-id, with e.g. a modalias of: "i2c:axp209". >> >> Populate the axp20x_i2c_id[] table with supported ids, so that >> module auto-loading will work. >> >> Reported-by: Dennis Gilmore >> Signed-off-by: Hans de Goede > > Acked-by: Chen-Yu Tsai > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > would it make sense to add DT-based module autoloading to the i2c > core? If it is not too invasive, then yes that would be a sensible addition IMHO. Regards, Hans