public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Vincent Legoll <legoll@online.fr>
To: linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Yixun Lan <dlan@kernel.org>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
Date: Mon, 6 Apr 2026 23:55:25 +0200	[thread overview]
Message-ID: <bbd2e57f-3107-46cc-a8a7-ee717e577d6e@online.fr> (raw)
In-Reply-To: <adPUTRAlzGBs2wQG@aurel32.net>

Hi Aurelien,

On 4/6/26 17:42, Aurelien Jarno wrote:
> On 2026-04-06 11:46, Vincent Legoll wrote:
>> Tell me if there's a new iteration to test, and/or if you want me testing it
>> in a different way.
> Yes, as written in the original mail, this patchset depends on PIO
> support in the spacemit I2C driver:
> https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/
>
> Without it, you might get this warning message and reboot is not 100%
> reliable. I still believe it's better than no reboot support at all.


OK, I tested a new stack: next-20260406, PIO patchset, reset patchset & 
USB patchset:


$ git log --oneline
5030369b32c4 (HEAD -> opirv2-pio-reset-usb) riscv: dts: spacemit: Enable 
USB3.0/PCIe on OrangePi RV2
73274ce37441 riscv: dts: spacemit: Define the P1 PMIC regulators for 
OrangePi RV2
cda12b8bdbfe riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
68ce409351c6 (opirv2-pio-reset) mfd: simple-mfd-i2c: add a reboot cell 
for the SpacemiT P1 chip
245e0b8e8a91 i2c: spacemit: introduce pio for k1
a588d756621d i2c: spacemit: move i2c_xfer_msg()
816f193dd0d9 (tag: next-20260406, next/master, next/HEAD) Add linux-next 
specific files for 20260406

This boots and reset properly without the previous WARN.

So if any of those those series need added T-Bs, then here's mine:

Tested-by: Vincent Legoll<legoll@online.fr> # OrangePi-RV2

I also believe this is better than nothing: reboot + (harmless) WARN instead of hang.

PS: I added recipients for the PIO patchset as CC here, for the T-B, hope this is not bothering.

Thanks



       reply	other threads:[~2026-04-06 21:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260401165437.1048786-3-aurelien@aurel32.net>
     [not found] ` <b7e182f9-8bd8-40e6-acaa-dc6e556f2a53@online.fr>
     [not found]   ` <adPUTRAlzGBs2wQG@aurel32.net>
2026-04-06 21:55     ` Vincent Legoll [this message]
2026-04-08  2:48       ` [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbd2e57f-3107-46cc-a8a7-ee717e577d6e@online.fr \
    --to=legoll@online.fr \
    --cc=andi.shyti@kernel.org \
    --cc=aurelien@aurel32.net \
    --cc=dlan@gentoo.org \
    --cc=dlan@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox