From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F505EB64DA for ; Wed, 14 Jun 2023 12:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236513AbjFNMCY (ORCPT ); Wed, 14 Jun 2023 08:02:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243186AbjFNMCX (ORCPT ); Wed, 14 Jun 2023 08:02:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60E9E19A5; Wed, 14 Jun 2023 05:02:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E804464171; Wed, 14 Jun 2023 12:02:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91737C433C8; Wed, 14 Jun 2023 12:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686744141; bh=Ndt3qeBV1t7UZ/IrnN4tt6VjBFAtVfLwZMresw0Bg+M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TmaqT+pIvNRDcMhfZ8WrIBUDXP9SLxwHJCNLrimj1yS5T8nhLqAvwgG43JtWuj93z wEeJTxmOyxhYdN6Wmddc1EjsfOm6KsXkc+brCVgGg5i9Cxd4sv6j+XtFezJ3fHRgWB v1gywGb7OAmdSqdnTzHNXW7ucnBw8N095y2AZO4qTMbGXX/be4cmS/StZ3W4kzphfJ Tu6qKReqshLJ4gDUCo8izrHXbkByKqP7Hxws2NfTmr1QRzknnf/CFN/AFyaSvKfm5W LBQUwCBukvPtrNLUMC9+ntKP289QJd501djq2XB7f+mxZtn8lY49dNYWnU70i/EXO3 LNB43PGGndiIg== Message-ID: Date: Wed, 14 Jun 2023 14:02:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops To: Andi Shyti , Wang Ming Cc: Peter Korsgaard , Peter Rosin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com References: <20230614112903.667-1-machel@vivo.com> <20230614114339.zhuhij6vobdnbse5@intel.intel> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230614114339.zhuhij6vobdnbse5@intel.intel> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 14/06/2023 13:43, Andi Shyti wrote: > Hi Wang, > >> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c >> index 5d5cbe013..90966de7a 100644 >> --- a/drivers/i2c/muxes/i2c-mux-gpio.c >> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c >> @@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux, >> } else if (is_acpi_node(child)) { >> rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i); >> if (rc) >> + fwnode_handle_put(child); >> return dev_err_probe(dev, rc, "Cannot get address\n"); >> } > > please, read it again and tell me what's wrong :) No, we can't tell what's wrong because: > The contents of this message and any attachments may contain > confidential and/or privileged information :) Wang, Just run the sparse and smatch before posting patches. Best regards, Krzysztof