public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Encarnacion, Cedric justine" <Cedricjustine.Encarnacion@analog.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: trivial-devices: add lt3074
Date: Mon, 17 Feb 2025 11:52:09 +0100	[thread overview]
Message-ID: <bcadb20f-4867-4b77-ac53-f855b14cd746@kernel.org> (raw)
In-Reply-To: <PH0PR03MB693845F71D14B21D447D701A8EFB2@PH0PR03MB6938.namprd03.prod.outlook.com>

On 17/02/2025 10:30, Encarnacion, Cedric justine wrote:
>>
>>> LT7182S. Like other PMBus drivers, its GPIOs are not exposed.
>>>
>>> Here are other PMBus regulators/power modules found in trivial-devices
>>> I also used as reference:
>>>
>>> - infineon,irps5401
>>> - delta,q54sj108a2
>>
>>
>> I don't know these devices so still no clue. Please rather explain in
>> the terms of the hardware, e.g. what this device has or has not. See
>> also regulator bindings.
> 
> The device has enable-gpio and status-gpio. It also has registers of
> similar functionality which the core driver accesses instead for
> toggling enable and monitoring status of the device.
> 
> Upon checking regulator bindings and other related bindings for
> PMBus devices with regulator support, this indeed should be a
> separate binding outside of trivial devices. Please let me know
> what do you suggest.

Even the GPIOs are outside of trivial devices, so for that sole reason
this should not be here but in its own binding.

Best regards,
Krzysztof

  reply	other threads:[~2025-02-17 10:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24 15:39 [PATCH 0/2] Add support for LT3074 low voltage linear regulator Cedric Encarnacion
2025-01-24 15:39 ` [PATCH 1/2] dt-bindings: trivial-devices: add lt3074 Cedric Encarnacion
2025-01-27  7:52   ` Krzysztof Kozlowski
2025-02-06  9:05     ` Encarnacion, Cedric justine
2025-02-09 12:01       ` Krzysztof Kozlowski
2025-02-17  9:30         ` Encarnacion, Cedric justine
2025-02-17 10:52           ` Krzysztof Kozlowski [this message]
2025-01-24 15:39 ` [PATCH 2/2] hwmon: (pmbus/lt3074): add support for lt3074 Cedric Encarnacion
2025-01-25 22:44   ` kernel test robot
2025-01-25 22:53   ` Guenter Roeck
2025-01-27 20:35   ` kernel test robot
2025-01-29 16:14   ` Guenter Roeck
2025-02-06  9:06     ` Encarnacion, Cedric justine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcadb20f-4867-4b77-ac53-f855b14cd746@kernel.org \
    --to=krzk@kernel.org \
    --cc=Cedricjustine.Encarnacion@analog.com \
    --cc=Delphine_CC_Chiu@wiwynn.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox