From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ren Subject: Re: [PATCH 1/2] i2c: aspeed: allow to customize base clock divisor Date: Thu, 20 Jun 2019 07:57:26 +0000 Message-ID: References: <20190619205009.4176588-1-taoren@fb.com> <18565fcf-3dc1-b671-f826-e4417e4ad284@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: <0FB3EA1C925D3F45868E5B7441BA38C2@namprd15.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ryan Chen , Brendan Higgins Cc: Mark Rutland , devicetree , "linux-aspeed@lists.ozlabs.org" , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , "linux-i2c@vger.kernel.org" , Linux ARM List-Id: linux-i2c@vger.kernel.org On 6/20/19 12:29 AM, Ryan Chen wrote: > Hello Tao, > Our recommend about clk divider setting is follow the datasheet clock setting table for clock divisor. > > Ryan Thanks Ryan for the response. Could you also share some recommendations/hints on how to solve the intermittent i2c transaction failures on Facebook AST2500 BMC platforms? BTW, the patch is not aimed at modifying the existing formula of calculating clock settings in i2c-aspeed driver: people still get the recommended settings by default. The goal of the patch is to allow people to customize clock settings in case the default/recommended one doesn't work. Cheers, Tao