From: Peter Rosin <peda@axentia.se>
To: Biwen Li <biwen.li@nxp.com>,
"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [v3,1/2] dt-bindings: i2c: support property idle-state
Date: Thu, 17 Oct 2019 15:38:14 +0000 [thread overview]
Message-ID: <bfdb97c1-76f4-52d9-7f02-c62bed8192ce@axentia.se> (raw)
In-Reply-To: <20191016040920.8511-1-biwen.li@nxp.com>
On 2019-10-16 06:09, Biwen Li wrote:
> This supports property idle-state
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
> Change in v3:
> - update subject and description
> - add some information for property idle-state
>
> Change in v2:
> - update subject and description
> - add property idle-state
>
> Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 30ac6a60f041..7abda506b828 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -25,6 +25,8 @@ Required Properties:
> Optional Properties:
>
> - reset-gpios: Reference to the GPIO connected to the reset input.
> + - idle-state: if present, overrides i2c-mux-idle-disconnect,
> + Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
> - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all
> children in idle state. This is necessary for example, if there are several
> multiplexers on the bus and the devices behind them use same I2C addresses.
>
Rob, should i2c-mux-idle-disconnect perhaps be deprecated here? Is that
appropriate?
idle-state provides a super-set of what i2c-mux-idle-disconnect provides.
Cheers,
Peter
next prev parent reply other threads:[~2019-10-17 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 4:09 [v3,1/2] dt-bindings: i2c: support property idle-state Biwen Li
2019-10-16 4:09 ` [v3,2/2] i2c: mux: pca954x: " Biwen Li
2019-10-17 15:40 ` Peter Rosin
2019-10-21 7:40 ` [EXT] " Biwen Li
2019-10-17 14:54 ` [v3,1/2] dt-bindings: i2c: " Rob Herring
2019-10-17 15:38 ` Peter Rosin [this message]
2019-10-17 16:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfdb97c1-76f4-52d9-7f02-c62bed8192ce@axentia.se \
--to=peda@axentia.se \
--cc=biwen.li@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox