From: Dmitry Osipenko <digetx@gmail.com>
To: LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@microchip.com>,
wsa@kernel.org, andriy.shevchenko@linux.intel.com,
treding@nvidia.com, mirq-linux@rere.qmqm.pl, s.shtylyov@omp.ru,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module
Date: Thu, 7 Oct 2021 19:15:10 +0300 [thread overview]
Message-ID: <c0ad0472-16df-ef45-61cb-27e81bfeb9b5@gmail.com> (raw)
In-Reply-To: <43c25d97a64010b9785a4cd75821564d511bc090.camel@microchip.com>
05.10.2021 11:48, LakshmiPraveen Kopparthi пишет:
> On Wed, 2021-09-29 at 10:20 +0300, Dmitry Osipenko wrote:
>> [Some people who received this message don't often get email from
>> digetx@gmail.com. Learn why this is important at
>> http://aka.ms/LearnAboutSenderIdentification.]
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет:
>>> Read and Write callbacks for PCI1XXXX I2C adapter is added.
>>>
>>> Signed-off-by: LakshmiPraveen Kopparthi <
>>> LakshmiPraveen.Kopparthi@microchip.com>
>>> ---
>>> drivers/i2c/busses/i2c-mchp-pci1xxxx.c | 485
>>> +++++++++++++++++++++++++
>>> 1 file changed, 485 insertions(+)
>>
>> Why this is a separate patch?
>
> I thought of splitting the driver into two patches.
> 1. Contains the intialisations,ISR, supend and resume callbacks.
> 2. Contains read and write functions.
> If it make sense to merge these into a single patch, I will do it.
Please combine it all into a single patch. In general it's better to
have a single patch for new drivers since it's easier to review.
prev parent reply other threads:[~2021-10-07 16:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:22 [PATCH v1 0/2] i2c:busses:Microchip PCI1XXXX I2C adapter LakshmiPraveen Kopparthi
2021-09-29 6:22 ` [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem LakshmiPraveen Kopparthi
2021-09-29 7:18 ` Dmitry Osipenko
2021-09-29 14:35 ` Dmitry Osipenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-09-29 16:44 ` Andy Shevchenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-10-05 8:50 ` LakshmiPraveen Kopparthi
2021-10-07 16:24 ` Dmitry Osipenko
2021-10-07 16:33 ` Andy Shevchenko
2021-10-07 16:30 ` Dmitry Osipenko
2021-09-29 17:12 ` Michał Mirosław
2021-10-08 6:22 ` LakshmiPraveen Kopparthi
2021-10-07 16:40 ` Dmitry Osipenko
2021-10-07 17:05 ` Andy Shevchenko
2021-09-29 6:22 ` [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module LakshmiPraveen Kopparthi
2021-09-29 7:20 ` Dmitry Osipenko
2021-10-05 8:48 ` LakshmiPraveen Kopparthi
2021-10-07 16:15 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0ad0472-16df-ef45-61cb-27e81bfeb9b5@gmail.com \
--to=digetx@gmail.com \
--cc=LakshmiPraveen.Kopparthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=s.shtylyov@omp.ru \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).