From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A057A16A935; Mon, 19 Aug 2024 12:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.32 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724070189; cv=none; b=Xg67RUWHesuVWrcMPkD5EtvSEsTeiWB/PsHI+D1CRdFrG3Abtr4ZyhgHa4GDAfDZwrakbRLklI18FxRb+FemVJ5idfvG7rxMx2m1X6KtiadDHsJha7TbzzeG1uZzkacnI3pyDtHP2NMXtBXw1nhuh8sBRPOJWDlY2l4Z5GNn/jk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724070189; c=relaxed/simple; bh=/AtrqrhMsfGN0cqRpWB0QbkwVbz4Zv7nCRd8FMe9y4I=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=clL+zrZuM+KgQzfB4pZcWxM/l0xlIVGaHbQL5tspcDCT4kDSLcZNCgV1AqgnpLLk+l0UDDpyVOml2vfTb5FhHV8yvOIxBj0iqkratzavuhgkZ+qo+04lE9npdwlnOVIU6d2EplVn0SfNHEN1H3MoWCuONCQhJA3Bm49PA0p7u88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4WnWsf0Zhzz1xvVw; Mon, 19 Aug 2024 20:21:10 +0800 (CST) Received: from kwepemg500010.china.huawei.com (unknown [7.202.181.71]) by mail.maildlp.com (Postfix) with ESMTPS id B32BC14011F; Mon, 19 Aug 2024 20:23:03 +0800 (CST) Received: from [10.67.109.211] (10.67.109.211) by kwepemg500010.china.huawei.com (7.202.181.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 19 Aug 2024 20:23:02 +0800 Message-ID: Date: Mon, 19 Aug 2024 20:23:01 +0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -next 0/9] drivers: fix some module autoloading Content-Language: en-US To: Arnd Bergmann , , , , , "linux-edac@vger.kernel.org" , , CC: Alexandre Belloni , Claudiu Beznea , Robert Jarzmik , Andy Shevchenko , Corey Minyard , Ludovic.Desroches , Alan Stern , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , , =?UTF-8?Q?Duje_Mihanovi=C4=87?= , Robert Richter , Andi Shyti , Haojian Zhuang , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , , Greg Kroah-Hartman , Vinod Koul , Mark Brown , James Morse , Daniel Mack References: <20240819113855.787149-1-liuyuntao12@huawei.com> From: "liuyuntao (F)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemg500010.china.huawei.com (7.202.181.71) yes sir^^. Regards! Yuntao On 2024/8/19 20:09, Arnd Bergmann wrote: > On Mon, Aug 19, 2024, at 13:38, Yuntao Liu wrote: >> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded >> based on the alias from platform_device_id table. >> >> Yuntao Liu (9): >> usb: ehci-mv: fix module autoloading >> soc: pxa: ssp: fix module autoloading >> misc: atmel-ssc: fix module autoloading >> i2c: at91: fix module autoloading >> mpc85xx_edac: fix module autoloading >> dmaengine: pxa: fix module autoloading >> dmaengine: mmp_pdma: fix module autoloading >> dmaengine: at_hdmac: fix module autoloading >> ipmi: ipmi_ssif: fix module autoloading > > I looked at all the patches and found that most of them do not > use the table any more, or will stop using it in the near future. > > I think your work to validate the correctness of the entries > is useful, but it may be more helpful to focus on removing > all the unused tables, including those that have a > MODULE_DEVICE_TABLE() tag. > > If you are planning to do more such cleanups, maybe you can > go through them one subsystem at a time and look for drivers > that have both of_device_id and i2c_device_id/platform_device_id/ > spi_device_id tables. If nothing in the kernel creates a device > with the legacy string, you can then send a patch that removes > the old device ID list and at the same time makes the DT support > unconditional in case there is an #ifdef CONFIG_OF check. > > If the probe() function accesses platform_data, this would also > be unused, allowing an even nicer cleanup of removing the > platofrm_data path in favor of OF properties. > > Arnd