Re: [PATCH v4 5/6] i2c: smbus: Support DDR5 SPD EEPROMs

[Paul Menzel <pmenzel@molgen.mpg.de>]

Dear Guenter,


Am 18.06.24 um 17:12 schrieb Guenter Roeck:
> On 6/18/24 07:59, Paul Menzel wrote:

>> Am 18.06.24 um 16:23 schrieb Guenter Roeck:
>>> On 6/18/24 06:51, Paul Menzel wrote:
>>
>>>> Am 18.06.24 um 15:32 schrieb Guenter Roeck:
>>>>
>>>>> On 6/18/24 03:25, Paul Menzel wrote:
>>>>> [ ... ]
>>>>>>
>>>>>>      $ ls -l /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>>>>      -r--r--r-- 1 root root 1024 Jun 18 12:17  /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>>>>      $ cp /sys/bus/i2c/drivers/spd5118/0-0050/eeprom /tmp
>>>>>>      cp: error reading '/sys/bus/i2c/drivers/spd5118/0-0050/eeprom': No such device or address
>>>>>
>>>>> That suggests that the i801 driver got an error when trying some 
>>>>> chip operation.
>>>>> Unfortunately I have no idea what that error or the failed 
>>>>> operation might be.
>>>>>
>>>>>>      $ od -t x1 /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>>>>      od: /sys/bus/i2c/drivers/spd5118/0-0050/eeprom: read error: No such device or address
>>>>>>      0000000
>>>>>>
>>>>>>> sudo i2cdump -y -f 0 0x50
>>>>>>
>>>>>>      $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cdump -y -f 0 0x50
>>>>>>      No size specified (using byte-data access)
>>>>>>      Error: Could not open file `/dev/i2c-0' or `/dev/i2c/0': No such file or directory
>>>>>>
>>>>> This should work after you load the "i2c-dev" module.
>>>>
>>>> Silly me. Thank you.
>>>>
>>>>> If you get it to work, please provide the output. Maybe it helps 
>>>>> tracking down the problem.
>>>>
>>>> ```
>>>> $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cdump -y -f 0 0x50
>>>> No size specified (using byte-data access)
>>>>       0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    
>>>> 0123456789abcdef
>>>> 00: 51 18 0a 86 32 03 32 00 00 00 00 00 ff 01 00 00    Q???2?2......?..
>>>> 10: 00 00 00 00 00 00 00 00 00 00 00 00 70 03 00 00    ............p?..
>>>> 20: 50 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00    P?..............
>>>> 30: 00 58 01 00 00 00 00 00 00 00 00 00 00 00 00 00    .X?.............
>>>> 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> 80: 30 10 12 02 04 00 20 62 00 00 00 00 90 02 00 00    0????. b....??..
>>>> 90: 00 00 00 00 a0 01 f2 03 7a 0d 00 00 00 00 80 3e    ....????z?....?>
>>>> a0: 80 3e 80 3e 00 7d 80 bb 30 75 27 01 a0 00 82 00    ?>?>.}??0u'??.?.
>>>> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> c0: 00 00 00 00 00 00 88 13 08 88 13 08 20 4e 20 10    ......?????? N ?
>>>> d0: 27 10 15 34 20 10 27 10 c4 09 04 4c 1d 0c 00 00    '??4 ?'????L??..
>>>> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
>>>> ```
>>>>
>>>> So (00,b) = 0x00 opposed to 0x07 in your example output.
>>>>
>>>
>>> Yes, that assumed that reading the nvram/eeprom succeeded, which it didn't.
>>> The value might also be 7 directly after booting and before loading
>>> the spd5118 driver.
>>>
>>> Anyway, it almost looks like setting the page doesn't work, or maybe write
>>> operations in general.
>>>
>>> Can you try the following ?
>>>
>>> dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom 
>>> count=64 bs=1
>>>
>>> and
>>>
>>> dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom 
>>> count=1 bs=64
>>>
>>> That should only try to read from page 0.
>>
>>      $ sudo dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom count=64 bs=1
>>      64+0 records in
>>      64+0 records out
>>      64 bytes copied, 0.046002 s, 1.4 kB/s
>>      $ sudo dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom count=1 bs=64
>>      1+0 records in
>>      1+0 records out
>>      64 bytes copied, 0.000215414 s, 297 kB/s
>>
>>> Also, please try to set a temperature limit, either temp1_max
>>> or temp1_crit. Setting temp1_max to, say, 56000, or temp1_crit
>>> to 84000 should do.
>>
>> I did
>>
>>      $ tail -3 /etc/sensors3.conf
>>      chip "spd5118-*"
>>          set temp1_max 56000
>>          set temp1_crit 84000
>>
>> but it stays with the defaults:
>>
>> ```
>> $ sensors
> 
> Did you run "sudo sensors -s" ?

No, I did not.

> I don't know if that would report errors, though.

It looks like it does:

     $ sudo sensors -s
     Error: File /etc/sensors3.conf, line 522: Failed to set value
     Error: File /etc/sensors3.conf, line 523: Failed to set value
     spd5118-i2c-0-53: At least one "set" statement failed
     Error: File /etc/sensors3.conf, line 522: Failed to set value
     Error: File /etc/sensors3.conf, line 523: Failed to set value
     spd5118-i2c-0-51: At least one "set" statement failed
     Error: File /etc/sensors3.conf, line 522: Failed to set value
     Error: File /etc/sensors3.conf, line 523: Failed to set value
     spd5118-i2c-0-52: At least one "set" statement failed
     Error: File /etc/sensors3.conf, line 522: Failed to set value
     Error: File /etc/sensors3.conf, line 523: Failed to set value
     spd5118-i2c-0-50: At least one "set" statement failed


Kind regards,

Paul