From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH v1 1/2] i2c: designware: Make master module optional
Date: Wed, 25 Mar 2020 09:47:47 +0200 [thread overview]
Message-ID: <c3d2d5ff-605a-bdb7-275b-872fdfd10ccd@linux.intel.com> (raw)
In-Reply-To: <20200323100451.28808-1-andriy.shevchenko@linux.intel.com>
On 3/23/20 12:04 PM, Andy Shevchenko wrote:
> In some cases we know that the controller will be always used in slave mode and
> master is just a bulk. In order to drop that, introduce a separate configuration
> parameter for master mode. Default it to core to avoid regressions.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/i2c/busses/Kconfig | 10 ++++++++++
> drivers/i2c/busses/Makefile | 5 ++++-
> drivers/i2c/busses/i2c-designware-core.h | 19 ++++++++++++++++++-
> drivers/i2c/busses/i2c-designware-master.c | 4 ++--
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> drivers/i2c/busses/i2c-designware-platdrv.c | 6 +-----
> 6 files changed, 36 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 2ddca08f8a76..1df238ff8dd0 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -527,6 +527,16 @@ config I2C_DAVINCI
> config I2C_DESIGNWARE_CORE
> tristate
>
> +config I2C_DESIGNWARE_MASTER
> + bool "Synopsys DesignWare Master"
> + default I2C_DESIGNWARE_CORE
> + help
> + If you say yes to this option, support will be included for the
> + Synopsys DesignWare I2C master adapter.
> +
> + This is not a standalone module, this module compiles together with
> + i2c-designware-core.
> +
I think we should go to a opposite direction - reduce the number of
I2C_DESIGNWARE_ config options rather than add new ones. We already have
5 config options for it.
Size of i2c-designware-core.ko is around 12 kB with all master, slave
and Baytrail semaphore code built in so I don't think it justifies the
added config complexity. I think distributions will have anyway all of
those options set.
Having those code in separate modules and load only when needed might
make sense as that would save a few kB of RAM.
--
Jarkko
next prev parent reply other threads:[~2020-03-25 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 10:04 [PATCH v1 1/2] i2c: designware: Make master module optional Andy Shevchenko
2020-03-23 10:04 ` [PATCH v1 2/2] i2c: designware: Move configuration routines to respective modules Andy Shevchenko
2020-03-23 12:26 ` [PATCH v1 1/2] i2c: designware: Make master module optional Andy Shevchenko
2020-03-25 7:47 ` Jarkko Nikula [this message]
2020-03-25 11:45 ` Andy Shevchenko
2020-04-15 11:37 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d2d5ff-605a-bdb7-275b-872fdfd10ccd@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).