From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD95C31A61 for ; Fri, 5 Jan 2024 16:34:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hZL7sbjc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704472450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TvrYVDC7Xe39kH8XwXBOfXEeoo0O4JfUtp7RmcXFdzY=; b=hZL7sbjckelNAr/9P1IKkDFRoQXahZWWtmL//3wqrPLoqcxuNR/gONcjN3Z5pSPz9TgE1c +kAqLVRKiimZBXMHWe4pcaM78EFjWD20Ir2Xkkpq5PUkWD0iRsMtY/208NRPIOLPTrFmYA XZjTnZNclmXV0yOM9ckr1SayMntD/D0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-qI5UbR5xOiCxGA6bc1c-Qw-1; Fri, 05 Jan 2024 11:34:09 -0500 X-MC-Unique: qI5UbR5xOiCxGA6bc1c-Qw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a275f860d04so70522166b.0 for ; Fri, 05 Jan 2024 08:34:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704472448; x=1705077248; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TvrYVDC7Xe39kH8XwXBOfXEeoo0O4JfUtp7RmcXFdzY=; b=P8TbQ0BdKRiHlU5XE57m5tWKIX/tNrLu5bdGXPBjAMnf6ZCh8hmqXLP+QluVf0a/Jy 3J94eUaz058HWbtkwnXD521l/xoWtHAVjy6IsSrkWa1INPPw5I6OSrwqPV9QY3gHNkvS F+De5eAtqBdzKXpslst7enCyB3W+tfwe1N9xM9TfxJcvSPPbysQ0Pc+wMNRaXvEdpShS URY2rM5rbvYvOIBpFNURLYhtU+o6K+LIZWVaLfSsXc/MYerNOTU4gwtLXaYF6RGMCBn8 8YFI10eAfRdlImU3dAsb7USqzkCYzwfQHbVFmgfTggl880PgTJ6iYJ4SidNxabOMWhyk LeFw== X-Gm-Message-State: AOJu0Yz6owu0N0AKKeM13zT1McuWgpYEjTBI1Gv8MHRDGOzfafvEKapP qEfiv0anHs71zWi2r2YsFpcrDlOxBEes1vcFEZX7BaynvkRtEdzz3a6/GgIVUSD3Pql64AR85zt gNuATWBSOlLrKY4Eq3oBJW9k5FjcX X-Received: by 2002:a17:906:458:b0:a26:e35b:9e1e with SMTP id e24-20020a170906045800b00a26e35b9e1emr1202798eja.109.1704472448517; Fri, 05 Jan 2024 08:34:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFybZWiIbWlOyg5WkjkHtKqX4oUAwM+7I6+fh4z3/048a79AUTSLrL0aXwZaOPZXWBEjPGlXA== X-Received: by 2002:a17:906:458:b0:a26:e35b:9e1e with SMTP id e24-20020a170906045800b00a26e35b9e1emr1202788eja.109.1704472448197; Fri, 05 Jan 2024 08:34:08 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id n4-20020a170906700400b00a27051a9eb6sm1049181ejj.148.2024.01.05.08.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 08:34:07 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 17:34:07 +0100 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] platform/x86: dell-smo8800: Instantiate an i2c_client for the IIO st_accel driver Content-Language: en-US, nl To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Jean Delvare , Andi Shyti , Eric Piel , Paul Menzel , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko , Dell.Client.Kernel@dell.com, Marius Hoch , Kai Heng Feng , Wolfram Sang , platform-driver-x86@vger.kernel.org, linux-i2c@vger.kernel.org References: <20231224213629.395741-1-hdegoede@redhat.com> <20231224213629.395741-6-hdegoede@redhat.com> <20231224220321.vqzb4q3ut3dz3rl2@pali> From: Hans de Goede In-Reply-To: <20231224220321.vqzb4q3ut3dz3rl2@pali> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, On 12/24/23 23:03, Pali Rohár wrote: > On Sunday 24 December 2023 22:36:21 Hans de Goede wrote: >> Instead of instantiating an i2c_client for the old misc joystick emulation >> and freefall driver: drivers/misc/lis3lv02d/lis3lv02d.c use >> i2c_client_id-s from the IIO st_accel driver so that the accelerometer >> gets presented to userspace as an IIO device like all modern accelerometer >> drivers do. >> >> Add a new use_misc_lis3lv02d module-parameter which can be set to restore >> the old behavior in case someone has a use-case depending on this. >> >> When the st_accel IIO driver is used, also pass the IRQ to the i2c_client >> and disable the /dev/freefall chardev. >> >> Signed-off-by: Hans de Goede >> --- >> drivers/platform/x86/dell/dell-smo8800.c | 82 ++++++++++++++++++++++-- >> 1 file changed, 78 insertions(+), 4 deletions(-) > > Sorry for the stupid question there, but what is the replacement for the > /dev/freefall when using new st_accel IIO driver? There is no replacement for /dev/freefall. I realize this is not ideal and if this turns out to be a problem the default of the module option can be reverted. But AFAIK / AFAICT there are no actual userspace consumers of /dev/freefall so removing it should not be an issue. Specifically I checked smartmontools which ships smartd which is the only daemon which I know of for hdd monitoring and that does not have /dev/freefall support. So /dev/freefall appears to be unused to me ? For completeness I also checked libatasmart which also does not access /dev/freefall. Regards, Hans