Re: [PATCH 11/13] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole

Sam Protsenko
2023-12-14T15:55:15Z

On Thu, Dec 14, 2023 at 4:53 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> Enable the eeprom found on the battery connector.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> .../boot/dts/exynos/google/gs101-oriole.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> index 4a71f752200d..11b299d21c5d 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts
> @@ -63,6 +63,19 @@ &ext_200m {
> clock-frequency = <200000000>;
> };
>
> +&hsi2c_8 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&hsi2c8_bus>;
> + #address-cells = <1>;
> + #size-cells = <0>;

Not sure if those 4 above properties belong in board's dts or in SoC's
dtsi. Krzysztof, what do you think?

Other than that:

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> + status = "okay";
> +
> + eeprom: eeprom@50 {
> + compatible = "atmel,24c08";
> + reg = <0x50>;
> + };
> +};
> +
> &pinctrl_far_alive {
> key_voldown: key-voldown-pins {
> samsung,pins = "gpa7-3";
> @@ -99,6 +112,11 @@ &usi_uart {
> status = "okay";
> };
>
> +&usi8 {
> + samsung,mode = <USI_V2_I2C>;
> + status = "okay";
> +};
> +
> &watchdog_cl0 {
> timeout-sec = <30>;
> status = "okay";
> --
> 2.43.0.472.g3155946c3a-goog
>