Re: [PATCH 02/13] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit

Sam Protsenko
2023-12-14T15:12:13Z

On Thu, Dec 14, 2023 at 4:52 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0)
> clock management unit.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---
> .../bindings/clock/google,gs101-clock.yaml | 25 +++++-
> include/dt-bindings/clock/google,gs101.h | 86 +++++++++++++++++++
> 2 files changed, 109 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> index 3eebc03a309b..ba54c13c55bc 100644
> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
> @@ -30,14 +30,15 @@ properties:
> - google,gs101-cmu-top
> - google,gs101-cmu-apm
> - google,gs101-cmu-misc
> + - google,gs101-cmu-peric0
>
> clocks:
> minItems: 1
> - maxItems: 2
> + maxItems: 3
>
> clock-names:
> minItems: 1
> - maxItems: 2
> + maxItems: 3
>
> "#clock-cells":
> const: 1
> @@ -88,6 +89,26 @@ allOf:
> - const: dout_cmu_misc_bus
> - const: dout_cmu_misc_sss
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: google,gs101-cmu-peric0
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: External reference clock (24.576 MHz)
> + - description: Connectivity Peripheral 0 bus clock (from CMU_TOP)
> + - description: Connectivity Peripheral 0 IP clock (from CMU_TOP)
> +
> + clock-names:
> + items:
> + - const: oscclk
> + - const: dout_cmu_peric0_bus
> + - const: dout_cmu_peric0_ip
> +
> additionalProperties: false
>
> examples:
> diff --git a/include/dt-bindings/clock/google,gs101.h b/include/dt-bindings/clock/google,gs101.h
> index 21adec22387c..7d7a896416a7 100644
> --- a/include/dt-bindings/clock/google,gs101.h
> +++ b/include/dt-bindings/clock/google,gs101.h
> @@ -389,4 +389,90 @@
> #define CLK_GOUT_MISC_WDT_CLUSTER1_PCLK 73
> #define CLK_GOUT_MISC_XIU_D_MISC_ACLK 74
>
> +/* CMU_PERIC0 */

This comments looks off here. Other than than, LGTM:

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> +/* CMU_PERIC0 MUX */
> +#define CLK_MOUT_PERIC0_BUS_USER 1
> +#define CLK_MOUT_PERIC0_I3C_USER 2
> +#define CLK_MOUT_PERIC0_USI0_UART_USER 3
> +#define CLK_MOUT_PERIC0_USI14_USI_USER 4
> +#define CLK_MOUT_PERIC0_USI1_USI_USER 5
> +#define CLK_MOUT_PERIC0_USI2_USI_USER 6
> +#define CLK_MOUT_PERIC0_USI3_USI_USER 7
> +#define CLK_MOUT_PERIC0_USI4_USI_USER 8
> +#define CLK_MOUT_PERIC0_USI5_USI_USER 9
> +#define CLK_MOUT_PERIC0_USI6_USI_USER 10
> +#define CLK_MOUT_PERIC0_USI7_USI_USER 11
> +#define CLK_MOUT_PERIC0_USI8_USI_USER 12
> +
> +/* CMU_PERIC0 Dividers */
> +#define CLK_DOUT_PERIC0_I3C 13
> +#define CLK_DOUT_PERIC0_USI0_UART 14
> +#define CLK_DOUT_PERIC0_USI14_USI 15
> +#define CLK_DOUT_PERIC0_USI1_USI 16
> +#define CLK_DOUT_PERIC0_USI2_USI 17
> +#define CLK_DOUT_PERIC0_USI3_USI 18
> +#define CLK_DOUT_PERIC0_USI4_USI 19
> +#define CLK_DOUT_PERIC0_USI5_USI 20
> +#define CLK_DOUT_PERIC0_USI6_USI 21
> +#define CLK_DOUT_PERIC0_USI7_USI 22
> +#define CLK_DOUT_PERIC0_USI8_USI 23
> +
> +/* CMU_PERIC0 Gates */
> +#define CLK_GOUT_PERIC0_IP 24
> +#define CLK_GOUT_PERIC0_PERIC0_CMU_PERIC0_PCLK 25
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_OSCCLK_CLK 26
> +#define CLK_GOUT_PERIC0_D_TZPC_PERIC0_PCLK 27
> +#define CLK_GOUT_PERIC0_GPC_PERIC0_PCLK 28
> +#define CLK_GOUT_PERIC0_GPIO_PERIC0_PCLK 29
> +#define CLK_GOUT_PERIC0_LHM_AXI_P_PERIC0_I_CLK 30
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_0 31
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_1 32
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_10 33
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_11 34
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_12 35
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_13 36
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_14 37
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_15 38
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_2 39
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_3 40
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_4 41
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_5 42
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_6 43
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7 44
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_8 45
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_9 46
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_0 47
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_1 48
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_10 49
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_11 50
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_12 51
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_13 52
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_14 53
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_15 54
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_2 55
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_3 56
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_4 57
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_5 58
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_6 59
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7 60
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_8 61
> +#define CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_9 62
> +#define CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0 63
> +#define CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_2 64
> +#define CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_0 65
> +#define CLK_GOUT_PERIC0_PERIC0_TOP1_PCLK_2 66
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_BUSP_CLK 67
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_I3C_CLK 68
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK 69
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI14_USI_CLK 70
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI1_USI_CLK 71
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI2_USI_CLK 72
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI3_USI_CLK 73
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI4_USI_CLK 74
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI5_USI_CLK 75
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI6_USI_CLK 76
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI7_USI_CLK 77
> +#define CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK 78
> +#define CLK_GOUT_PERIC0_SYSREG_PERIC0_PCLK 79
> +
> #endif /* _DT_BINDINGS_CLOCK_GOOGLE_GS101_H */
> --
> 2.43.0.472.g3155946c3a-goog
>