Re: [PATCH 02/13] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit

Tudor Ambarus
2023-12-21T07:20:40Z

On 12/20/23 15:07, Rob Herring wrote:
> On Thu, Dec 14, 2023 at 10:52:32AM +0000, Tudor Ambarus wrote:
>> Add dt-schema documentation for the Connectivity Peripheral 0 (PERIC0)
>> clock management unit.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
>> ---
>> .../bindings/clock/google,gs101-clock.yaml | 25 +++++-
>> include/dt-bindings/clock/google,gs101.h | 86 +++++++++++++++++++
>> 2 files changed, 109 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
>> index 3eebc03a309b..ba54c13c55bc 100644
>> --- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
>> +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml
>> @@ -30,14 +30,15 @@ properties:
>> - google,gs101-cmu-top
>> - google,gs101-cmu-apm
>> - google,gs101-cmu-misc
>> + - google,gs101-cmu-peric0
>>
>> clocks:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
>>
>> clock-names:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
>>
>> "#clock-cells":
>> const: 1
>> @@ -88,6 +89,26 @@ allOf:
>> - const: dout_cmu_misc_bus
>> - const: dout_cmu_misc_sss
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: google,gs101-cmu-peric0
>> +
>> + then:
>> + properties:
>> + clocks:
>> + items:
>> + - description: External reference clock (24.576 MHz)
>> + - description: Connectivity Peripheral 0 bus clock (from CMU_TOP)
>> + - description: Connectivity Peripheral 0 IP clock (from CMU_TOP)
>> +
>> + clock-names:
>> + items:
>> + - const: oscclk
>> + - const: dout_cmu_peric0_bus
>> + - const: dout_cmu_peric0_ip
>
> 'bus' and 'ip' are sufficient because naming is local to the module. The
> same is true on 'dout_cmu_misc_bus'. As that has not made a release,
> please fix all of them.
>

Ok, will fix them shortly. Thanks, Rob!