Re: [PATCH 04/13] dt-bindings: serial: samsung: gs101: make reg-io-width required property

Sam Protsenko
2023-12-14T15:14:37Z

On Thu, Dec 14, 2023 at 4:52 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote:
>
> GS101 only allows 32-bit register accesses. When using 8-bit reg
> accesses on gs101, a SError Interrupt is raised causing the system
> unusable.
>
> Make reg-io-width a required property and expect for it a value of 4.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
> ---

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>

> Documentation/devicetree/bindings/serial/samsung_uart.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> index 133259ed3a34..cc896d7e2a3d 100644
> --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml
> @@ -143,6 +143,10 @@ allOf:
> then:
> required:
> - samsung,uart-fifosize
> + - reg-io-width
> + properties:
> + reg-io-width:
> + const: 4
>
> unevaluatedProperties: false
>
> --
> 2.43.0.472.g3155946c3a-goog
>