From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Chiang, AlanX" <alanx.chiang@intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Yeh, Andy" <andy.yeh@intel.com>,
"Mani, Rajmohan" <rajmohan.mani@intel.com>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"brgl@bgdev.pl" <brgl@bgdev.pl>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] eeprom: at24: Add support for address-width property
Date: Tue, 26 Jun 2018 15:11:43 +0300 [thread overview]
Message-ID: <c4ad247dd1e0b4b13a2ca4e822bc569675556a7d.camel@linux.intel.com> (raw)
In-Reply-To: <0772C36F3434E145A062D024A4869A09010AA12F@PGSMSX101.gar.corp.intel.com>
On Tue, 2018-06-26 at 15:11 +0800, Chiang, AlanX wrote:
> If it is, I would like to modify it as below:
>
> case 8:
> If (chip->flags & AT24_FLAG_ADDR16) {
> chip->flags &= ~AT24_FLAG_ADDR16;
> dev_warn(dev, "address-width is 8, clear the ADDR16
> bit\n");
> }
> break;
No need to put bit clearing inside the loop, something like below would
be slightly better.
if (chip->flags & AT24_FLAG_ADDR16)
dev_warn(dev, "address-width is 8, clear the ADDR16 bit\n");
chip->flags &= ~AT24_FLAG_ADDR16;
On top of this the message would sound clearer if you put it like
"Override address width to be 8, while default is 16"
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-06-26 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 6:22 [PATCH v2 0/2] Add a property in at24.c alanx.chiang
2018-06-26 6:22 ` [PATCH v2 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-06-26 6:49 ` Sakari Ailus
2018-06-26 16:44 ` Rob Herring
2018-06-26 6:22 ` [PATCH v2 2/2] eeprom: at24: Add support for " alanx.chiang
2018-06-26 6:47 ` Sakari Ailus
2018-06-26 7:11 ` Chiang, AlanX
2018-06-26 7:26 ` Sakari Ailus
2018-06-26 12:11 ` Andy Shevchenko [this message]
2018-06-26 7:41 ` [PATCH v2 0/2] Add a property in at24.c Bartosz Golaszewski
2018-06-26 12:14 ` Andy Shevchenko
2018-06-26 12:36 ` Bartosz Golaszewski
2018-06-26 13:23 ` Andy Shevchenko
2018-06-26 13:30 ` Bartosz Golaszewski
2018-06-26 15:48 ` Andy Shevchenko
2018-06-26 16:21 ` Yeh, Andy
2018-06-26 16:31 ` Mani, Rajmohan
2018-06-26 16:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ad247dd1e0b4b13a2ca4e822bc569675556a7d.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alanx.chiang@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy.yeh@intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rajmohan.mani@intel.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).