From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, Chuhong Yuan <hslester96@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: busses: Use dev_get_drvdata where possible
Date: Mon, 29 Jul 2019 16:23:38 +0300 [thread overview]
Message-ID: <c58ef749-fae3-8df5-2d20-59d766256409@linux.intel.com> (raw)
In-Reply-To: <20190723203452.5714f142@endymion>
On 7/23/19 9:34 PM, Jean Delvare wrote:
> On Tue, 23 Jul 2019 19:11:10 +0800, Chuhong Yuan wrote:
>> Instead of using to_pci_dev + pci_get_drvdata,
>> use dev_get_drvdata to make code simpler.
>>
>> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
>> ---
>> drivers/i2c/busses/i2c-designware-pcidrv.c | 6 ++----
>> drivers/i2c/busses/i2c-i801.c | 3 +--
>> 2 files changed, 3 insertions(+), 6 deletions(-)
>> (...)
>
> Looks good to me, thanks.
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
For the i2c-designware-pcidrv.c
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2019-07-29 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 11:11 [PATCH] i2c: busses: Use dev_get_drvdata where possible Chuhong Yuan
2019-07-23 18:34 ` Jean Delvare
2019-07-29 13:23 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c58ef749-fae3-8df5-2d20-59d766256409@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=hslester96@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).