From: Romain Perier <romain.perier@free-electrons.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Wolfram Sang <wsa@the-dreams.de>, Hanna Hawa <hannah@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
Neta Zur Hershkovits <neta@marvell.com>,
linux-i2c@vger.kernel.org, Yahuda Yitschak <yehuday@marvell.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Omri Itach <omrii@marvell.com>, Rob Herring <robh+dt@kernel.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Marcin Wojtas <mw@semihalf.com>,
Igal Liberman <igall@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Shadi Ammouri <shadi@marvell.com>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 1/3] i2c: pxa: Add support for the I2C units found in Armada 3700
Date: Wed, 9 Nov 2016 10:55:04 +0100 [thread overview]
Message-ID: <c68c9d6b-b1e6-5bdd-7725-7c409da2df2d@free-electrons.com> (raw)
In-Reply-To: <20161109085946.cmd4ltaxpiojq7il@tarshish>
Hi Baruch
Le 09/11/2016 à 09:59, Baruch Siach a écrit :
>> @@ -193,6 +204,8 @@ struct pxa_i2c {
>> unsigned char master_code;
>> unsigned long rate;
>> bool highmode_enter;
>> + unsigned long fm_mask;
>> + unsigned long hs_mask;
>
> Do you really need 64bit for that?
>
> baruch
Mhhh, good point. No I think that I can use an unsigned int.
I will fix it.
Thanks,
Romain
--
Romain Perier, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-09 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 8:14 [PATCH v2 0/3] Add basic support for the I2C units of the Armada 3700 Romain Perier
[not found] ` <20161109081431.10115-1-romain.perier-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-09 8:14 ` [PATCH v2 1/3] i2c: pxa: Add support for the I2C units found in " Romain Perier
[not found] ` <20161109081431.10115-2-romain.perier-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-11-09 8:59 ` Baruch Siach
2016-11-09 9:55 ` Romain Perier [this message]
2016-11-09 8:14 ` [PATCH v2 2/3] arm64: dts: marvell: Add I2C definitions for the " Romain Perier
2016-11-09 8:14 ` [PATCH v2 3/3] dt-bindings: i2c: pxa: Update the documentation " Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c68c9d6b-b1e6-5bdd-7725-7c409da2df2d@free-electrons.com \
--to=romain.perier@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=igall@marvell.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=neta@marvell.com \
--cc=omrii@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wsa@the-dreams.de \
--cc=yehuday@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox