From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 004D7205ADC for ; Tue, 18 Mar 2025 21:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742334908; cv=none; b=mgpkmz2fYEI9lvnvcoPwW4hr5usb2LZj0ghpygOjRAezXj7tTGQ90uW/21bLRMGiYclbuoZeJwJWB3jX14tBP7e+MtgUdPw851QAHto3xrih45hKpCSBan8Um6KTEyEFph88Uvlz74l+Ubjkq8z+ffVzfP+VcKrPgxMibXF5MS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742334908; c=relaxed/simple; bh=hx3Sr4AFb5ucFf274orT/rk+C50ckIa8tHSb/t4lLeE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xg3uc5zBiNvK1qg/WJ9Wd4De79j6M7G80TPwOpUEYrgcB3aFUwc+7OOAKOqMSsc2X/zmQWUorVx6ctvM4xYkKPa7QfyApw60Xv/cEyx2b0KO+fUseAKIgBHGqoxn/eDmESkHEOVJC9zVknL8pqPXqfwqZohXDsqvc46homk+nhs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=bUn76Gjk; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="bUn76Gjk" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3cda56e1dffso32577525ab.1 for ; Tue, 18 Mar 2025 14:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1742334906; x=1742939706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BriU7gJk74pNPNWavKZMoPDwkWz3I9HqTPL00tnATHc=; b=bUn76GjkgvU9jKnorEuKFcJPQKmKiaOojEXT6mq6rBxO1fSywZ73KiTzN/Akumixsj uqt33nUAOonjdsFyQXdUQLyZyaHKtfsD6Y9Q269g9LzLbtixoRDqS9WbfjyFnLNYom0/ bTpUdo9oZFirjKaawnVj7ufreCQYoYvYSCt87h2mABvQT0XOzmXlzoxwu4QjJbRbPcOr /+a4+A55QvWhRyMW8fzbCxMJhfLVIK4uZPMpu1OcvjG8mXc6qtRFGXWwoaz0eOxLK82c 9Jpee4OiUnoeebX2TL0tH/YRKghq1hqCJ8ucRsVlCU1asECD5tXEIDRjs5X0ctNqTGl0 wqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742334906; x=1742939706; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BriU7gJk74pNPNWavKZMoPDwkWz3I9HqTPL00tnATHc=; b=a4Zj9Pnvqr9wdEGUkZ1pIgpus5PKGkWffbsyBeaSCyddOX5SCS/NDhYyRO7OE5ZQLC ssn1M/lPOa9tnta2cyhaLrXz7Om+lPOSlof2SxZSwCAWC/XKSBU6IE2GASNtGvQ/5CC4 7d9KBbJqWRZWLHlCjdoXRjJbD5G7+TSU+HNpBrB1NZKfDvr8/7zIo2CJrXv20btYcmlq iI/60knu2hM/upaXwFPOy0FeJ/7S+mllceIOAP1TAxgSxI1uV20FXtNgUEK/FCWS84Hp bF5ksh2xQSdTwHnjIMVpi20tK1UecLlzScSfn7RzwrBCPXvHFaYItxjtHEBmqC47OON/ H59A== X-Forwarded-Encrypted: i=1; AJvYcCW1FXQdqqqL2bK94XQRjS1zOHpddi9JxpXJnV3q/+/Pc9T+PKBclN4wMFu/E7VF8uV+nzTfndTAfHo=@vger.kernel.org X-Gm-Message-State: AOJu0YzrhB8bou7nwrIWPnZVmk4+lSZw/no0RxPzaaZJ3RMxZqkGp75z LadLM1F4Uai4g4yBzDwBMmvazsug90yYvt3sJYZC5Iphdx6n5wn5b+nnuFteGAg= X-Gm-Gg: ASbGncsogosjLtopOBysp6zWH5DpDiEfxw/Zk7Mr7cGZKx8X0uDbpBhpJOWaBHkPEvR pvK9tCjb29vuPXYu024sIukV27/uaCeooxs8W3CM4InUAlEiSZLNxcsNt+ywMoDvNdVOn5AcyDu FLtgAiw8LLS8fMdxBraCxBhz0ir9iAynHzFPaWaETYy5+sndZi2a5OAPA9yz8ouBYQF6n1FhYGO 6RuCqGBRM8CtpEot0AWqZJg/4e3fNnHLXkTEckBSEUwBlc/md1slP7z4XDChUpRV817R4xRFRiq KlMjhTTupyG3u0dfGQj06UxKt3smFNydQeC0gddSW6yiJdN5jB9cIDbM2Vvu3d3y1Qo/rqGtMir lkkUH7hsbt7aZPJNk8ME= X-Google-Smtp-Source: AGHT+IGVf9GbYQhaKGZToeaVO4iSrNen2V8aeAO2lkOMP+96+7ao9O222hC69zg9XeGwmJ/p4dFgUg== X-Received: by 2002:a05:6e02:2221:b0:3d3:faad:7c6f with SMTP id e9e14a558f8ab-3d586b2ab4cmr5124855ab.5.1742334906077; Tue, 18 Mar 2025 14:55:06 -0700 (PDT) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3d47a668e6asm35193745ab.28.2025.03.18.14.55.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 14:55:05 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2025 16:55:04 -0500 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/2] i2c: spacemit: add support for SpacemiT K1 SoC To: Andi Shyti Cc: Troy Mitchell , Alex Elder , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spacemit@lists.linux.dev References: <20250316-k1-i2c-master-v7-0-f2d5c43e2f40@gmail.com> <20250316-k1-i2c-master-v7-2-f2d5c43e2f40@gmail.com> <401059d0-6b2c-4c40-8c4d-51749dca27f3@ieee.org> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/18/25 4:41 PM, Andi Shyti wrote: > On Tue, Mar 18, 2025 at 07:04:19AM -0500, Alex Elder wrote: >> On 3/18/25 12:44 AM, Troy Mitchell wrote: >>>> I'll leave it up to the maintainer to decide whether these >>>> comments can just be ignored--my Reviewed-by is fine, even >>>> if you don't change these. >>>> >>>>                     -Alex >>> I know it's right what you said. >>> But I don't know if it's worth to send v8? >>> Maybe I can fix it when I add FIFO function? >>> If I'm wrong, let me know. >> >> Unless the maintainer wants you do do v8, please just >> address these suggestions later. Thank you. > > it's easier to just send it rather than asking for a v8 :-). You mean easier for Troy to just send an update? I agree with that. But I have no idea what Troy's schedule looks like... > What I care more is if you would give an r-b if your last > comment was addressed. If so Troy still has time to send a v8 to > get the series in this cycle, otherwise I can change things > myself before merging. It would be great to get this merged this week. Easiest, quickest, and most unambiguous (if you're willing) would be for you to do these tweaks and merge it. Or just merge v7 as-is. I don't really care at this point. Yes, my R-B stands with or without my suggestions here. Reviewed-by: Alex Elder Thank you. -Alex > Andi