From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout6-smtp.messagingengine.com (fout6-smtp.messagingengine.com [103.168.172.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CADEC77107; Fri, 13 Sep 2024 07:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726212957; cv=none; b=caEuFNy/bdKcuunjdh9mflLK8NwVocRJ6PjdEv9CFvlDxBrOogYkCRChxnTwIAbAsBvq0L+rMKOaQm9xgtvJW0LBZBso3kyN/jnWQ/kBUZvZmiMOLXQqGExSLa8cZ6QjRkkKqlaybKD6W/Tk2MSjj8sNGurtfQK59j9FXuNGfsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726212957; c=relaxed/simple; bh=vw3Wk39/2LGrnA3c7ll9JoJEwGZwwZJ02e3xBkNnQLM=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=VkiLDM4YttK9T230ycmSxiBDmtNjyAihz3UORebCgHKAXPvyo67BNyUY/mT7c2DnOOLbspj5DN6lALy9oTUup8d+UQ/LRtY4bsC0awes+IfRVIjrz0BQx9mjE+7Xh+/ASJDd9CnMrHmA+qOdygJN9cSpkcCiFjC3tL6Mvku1Wx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=mQXEeYxD; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=NPXTN6mG; arc=none smtp.client-ip=103.168.172.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="mQXEeYxD"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="NPXTN6mG" Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id E93A913805FC; Fri, 13 Sep 2024 03:35:54 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Fri, 13 Sep 2024 03:35:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1726212954; x=1726299354; bh=NGR5qqH9BPt1jFdj+yIMRlQVEYpFagFg+5zP2bRkTnQ=; b= mQXEeYxDf/GtHBQszb6qw4r5IV0XefG8dumxARrXOIekoQ0xJ1TYVpIaaR6h9WMH 1+oP77fOJJrUMojiWTvxnWupW14Wx6EDR/W/1QzHQsDqTsLk+INT9xSoBKSJYn4h /ZMgTdfIBZZ4gq2goKoI226kdBO0sm+SIrX+jAdVjoBTf7x/h2kJ/m5UFdOwLKo2 rn3iun8TP5APG/1FU0+7Mde6lYbSlPyA0mmFHTvWArjMx0yknUDjQZHUVzVPNBfY cWwBF6mihz0ZqVALfNACOyOU0olNNoVNIsjH9QHpkY27QvOwc2pD2EvpBKiR1MGm t9u3whrugopy8Bf1SeL0ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1726212954; x= 1726299354; bh=NGR5qqH9BPt1jFdj+yIMRlQVEYpFagFg+5zP2bRkTnQ=; b=N PXTN6mGjaX0AkN834hN0TRaL3yuuFmcvUNjWUvLlSqfpVwU8kbQIAQUNR4M7lOXn bZ5lYdFKdkWc0Q99Vi/5g1EefWq9z9zAx38kvsdavfp9HlKxch3+ui2/bHUY0c8U jJFS2iqpFNBLQbAw0cSS1lOeknWAvzhJOfhpTDIZtmZQwDWAIX4cHlPkRrqazxx7 aiPGCCbFlqBE2hgCB2jTUO4liCwtcFFy6HfDk0NvDXb7UcQdmweNX5tfbD2/LqHX r6Nef8AGrrZkoJ2fQhAAaYpy/BT5f8DETY6GdlBUp6NCsroP6TPY54/D1F50Qe74 LjzhrmWSH1HNvdFmwL6Tw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejiedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddt necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhephfdthfdvtdefhedukeetgefggffhjeeggeetfefg gfevudegudevledvkefhvdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvdek pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehuthhsrghvrdgrghgrrhifrghlse grnhgrlhhoghdrtghomhdprhgtphhtthhopegrughsphdqlhhinhhugiesrghnrghlohhg rdgtohhmpdhrtghpthhtoheprghrthhurhhsrdgrrhhtrghmohhnohhvshesrghnrghloh hgrdgtohhmpdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinhgrshesrghrmhdrtgho mhdprhgtphhtthhopehmthhurhhquhgvthhtvgessggrhihlihgsrhgvrdgtohhmpdhrtg hpthhtohepsghrghhlsegsghguvghvrdhplhdprhgtphhtthhopegrnhguihdrshhhhiht iheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlh drohhrghdprhgtphhtthhopehjihhrihhslhgrsgihsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id D76B7222006F; Fri, 13 Sep 2024 03:35:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 13 Sep 2024 07:35:33 +0000 From: "Arnd Bergmann" To: arturs.artamonovs@analog.com, "Catalin Marinas" , "Will Deacon" , "Greg Malysa" , "Philipp Zabel" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Utsav Agarwal" , "Michael Turquette" , "Stephen Boyd" , "Linus Walleij" , "Bartosz Golaszewski" , "Thomas Gleixner" , "Andi Shyti" , "Greg Kroah-Hartman" , "Jiri Slaby" , "Olof Johansson" , soc@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, adsp-linux@analog.com, "Nathan Barrett-Morrison" Message-Id: In-Reply-To: <20240912-test-v1-6-458fa57c8ccf@analog.com> References: <20240912-test-v1-0-458fa57c8ccf@analog.com> <20240912-test-v1-6-458fa57c8ccf@analog.com> Subject: Re: [PATCH 06/21] include: dt-binding: clock: add adi clock header file Content-Type: text/plain Content-Transfer-Encoding: 7bit On Thu, Sep 12, 2024, at 18:24, Arturs Artamonovs via B4 Relay wrote: > From: Arturs Artamonovs > > Add adi clock driver header file Are you sure this is necessary? If the clk controller follows a logical structure, it's usually easier to identify individual clks by the way the hardware is laid out. > +#ifndef DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > +#define DT_BINDINGS_CLOCK_ADI_SC5XX_CLOCK_H > + > +#define ADSP_SC598_CLK_DUMMY 0 > +#define ADSP_SC598_CLK_SYS_CLKIN0 1 > +#define ADSP_SC598_CLK_SYS_CLKIN1 2 > +#define ADSP_SC598_CLK_CGU0_PLL_IN 3 > +#define ADSP_SC598_CLK_CGU0_VCO_OUT 4 Unlike the DT compatible strings, these #defines don't have to be specific to a particular SoC, you could just reuse them for a family of chips even if they each use a slightly different subset. Maybe name them "ADSP_CLK_*" or "ADSP_SC5XX_CLK_*"? > +#define ADSP_SC598_CLK_END 80 This should not be part of the binding, in particular you probably want to be able to extend this in order to support additional chips. Arnd