Re: [PATCH v2 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible

Vladimir Zapolskiy
2025-10-15T19:30:26Z

On 10/15/25 05:56, Hangxiang Ma wrote:
> Add Kaanapali compatible consistent with CAMSS CCI interfaces. The list
> of clocks for Kaanapali requires its own compat string 'cam_top_ahb',
> aggregated into 'qcom,qcm2290-cci' node.
>
> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> index 9bc99d736343..0140c423f6f4 100644
> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
> @@ -25,6 +25,7 @@ properties:
>
> - items:
> - enum:
> + - qcom,kaanapali-cci
> - qcom,qcm2290-cci
> - qcom,sa8775p-cci
> - qcom,sc7280-cci
> @@ -128,6 +129,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,kaanapali-cci
> - qcom,qcm2290-cci
> then:
> properties:
> @@ -136,7 +138,9 @@ allOf:
> maxItems: 2
> clock-names:
> items:
> - - const: ahb
> + - enum:
> + - ahb
> + - cam_top_ahb

Why is not to give the clock "ahb" name like on QCM2290?

On QCM2290 the macro in front of the vlaue is GCC_CAMSS_TOP_AHB_CLK,
and name "ahb" is good for both, I believe.

> - const: cci
>
> - if:
>

--
Best wishes,
Vladimir