Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080

Bryan O'Donoghue
2025-10-16T10:18:35Z

On 16/10/2025 11:04, Bryan O'Donoghue wrote:
> drivers/media/platform/qcom/camss/camss-csid-gen3.c:        csid-
> >reg_update &= ~CSID_RUP_AUP_RDI(port_id);
> drivers/media/platform/qcom/camss/camss-csid-gen3.c:        csid-
> >reg_update |= CSID_RUP_AUP_RDI(port_id);
>
> and this in your code
>
>
> λ ~/Development/qualcomm/qlt-kernel/ linux-stable/master-reviews-
> oct15-25* grep aup_update drivers/media/platform/qcom/camss/*
>
> drivers/media/platform/qcom/camss/camss-csid-1080.c:static void
> __csid_aup_update(struct csid_device *csid, int port_id)
> drivers/media/platform/qcom/camss/camss-csid-1080.c:    csid->aup_update
> |= AUP_RDIN << port_id;

And now that I see the code side-by-side - also please use the
established macros and/or write a new macro to follow the established
pattern.

There's virtually no good argument to replicate a bit shift or twiddle -
that can be functionally decomposed and encapsulated in one place and
subsequently reused.

---
bod