From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DECAC43334 for ; Wed, 29 Jun 2022 08:23:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbiF2IXB (ORCPT ); Wed, 29 Jun 2022 04:23:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbiF2IXA (ORCPT ); Wed, 29 Jun 2022 04:23:00 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AACC93BF88 for ; Wed, 29 Jun 2022 01:22:59 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id d2so19264535ejy.1 for ; Wed, 29 Jun 2022 01:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=9FxvTXAyDoEN34ru1FkPgexZCj2uCfwrJpo+6ZTo0A4=; b=n/Rw+Jcn+siC9rHD66Q/a/Epxq2eyLv1bnipKrH7St50QwolhBFNC5OvHqYgS08cVM 44jVB/YmKBprD90NMtCEUcI3r7rxWA9edsn7cMFspPviKzEcXMYUNfdi/qNUdOZGfguQ SCw2ywbQ3RxV5BZVkOaUsWzz6KXF3o9zPurPpszTUZR65B0AnCAK5rWjjK+ODozaWxbc Ccoxi37IMKLiSWWRIxPQIaYjRRQVuJ2of6MlcCfOkSVFATNWz2OrvQQsaeQwu+3PzSDZ quLvYvP9vUPR521I25iXJY6gD6pdt1xUrltn/VOgfcLsxLK0EdY5omSh6/33SezquzAA cWhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9FxvTXAyDoEN34ru1FkPgexZCj2uCfwrJpo+6ZTo0A4=; b=vzRCJq95R73zMcIGDJ17OiXJpK+WJtqJU/DDhA4Irt6KUlQ36IzWCqLF5pnh45lxjb JaROkQu1Tl3A2yslqeIGCZfUEBCLjB1UtlNxzU3ZuWyZc/roMG+fXzuK/xyQ+o6ApWFV umdKVPa069M+ntvrfdtzxYHHL7Y6AF4RciMAKzE6raMhmyB2GI54Ok4LEhnk1OaMeiQp 0ymV6aoI5N/PKqgU3Yrl9W1bZL3shUH+HHW9eU2xQuHVU7pVdedyw85Q7asNMRYkMJ4H 50kvdCZ5jSRv3yt5RhXv0Sxulg/6e7RXZ5fz2H0vCKugKwi5dvR25hXF9NxGPmmVrS6C J2UQ== X-Gm-Message-State: AJIora8Kz0r9blmIHZTtkWpefA8ftibdOheD1xO0CLNAHXClFZc5AH8O lTSLDl6p7FhRtQ74eU8WtQLhhIeJ0zZ77g== X-Google-Smtp-Source: AGRyM1vBRN/0zJCCRrvFtMg3YT78GpkmpcLfz7O2iiWHYpoCUJQvH3PfgvAAcwtKOUT0zyul+rUioQ== X-Received: by 2002:a17:906:9c82:b0:6df:c5f0:d456 with SMTP id fj2-20020a1709069c8200b006dfc5f0d456mr2089497ejc.287.1656490978259; Wed, 29 Jun 2022 01:22:58 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id ia10-20020a170907a06a00b0070b7875aa6asm7286383ejc.166.2022.06.29.01.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jun 2022 01:22:57 -0700 (PDT) Message-ID: Date: Wed, 29 Jun 2022 10:22:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 1/2] dt-bindings: i2c: Document RZ/V2M I2C controller Content-Language: en-US To: Phil Edworthy , Rob Herring , Krzysztof Kozlowski Cc: Biju Das , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org References: <20220628194526.111501-1-phil.edworthy@renesas.com> <20220628194526.111501-2-phil.edworthy@renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20220628194526.111501-2-phil.edworthy@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 28/06/2022 21:45, Phil Edworthy wrote: > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > Signed-off-by: Phil Edworthy > Reviewed-by: Biju Das > --- > v2: > - Use an enum and set the default for clock-frequency > - Add resets property > --- > .../bindings/i2c/renesas,rzv2m.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > new file mode 100644 > index 000000000000..7f6d2bb4ecb3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/renesas,rzv2m.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2M I2C Bus Interface > + > +maintainers: > + - Phil Edworthy > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,i2c-r9a09g011 # RZ/V2M > + - const: renesas,rzv2m-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Data transmission/reception interrupt > + - description: Status interrupt > + > + interrupt-names: > + items: > + - const: tia > + - const: tis > + > + clock-frequency: > + default: 100000 > + enum: [ 100000, 400000 ] > + description: > + Desired I2C bus clock frequency in Hz. > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - power-domains > + - resets > + - '#address-cells' > + - '#size-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c0: i2c@a4030000 { > + compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c"; I missed that part in last version - you have some weird indentation here. Use 4 spaces for DTS example. Best regards, Krzysztof