答复: [PATCH v2 1/2] i2c: hisi: Optimized the value setting of maxwrite limit to fifo depth - 1

[liudingyuan <liudingyuan@huawei.com>]

Hi Andi

Yes, this is the only code change in version 2 compared to version 1. In addition,
in the commit description of PATCH v2 1/2 :
v1->v2
the threshold for FIFO empty interrupt 
->
the threshold for FIFO almost empty interrupt. 

In v2 2/2, there is no change.

Thanks,
Devyn
-----邮件原件-----
发件人: Andi Shyti <andi.shyti@kernel.org> 
发送时间: 2024年2月1日 14:52
收件人: liudingyuan <liudingyuan@huawei.com>
抄送: yangyicong <yangyicong@huawei.com>; Fangjian (Jay) <f.fangjian@huawei.com>; Jonathan Cameron <jonathan.cameron@huawei.com>; linux-i2c@vger.kernel.org
主题: Re: [PATCH v2 1/2] i2c: hisi: Optimized the value setting of maxwrite limit to fifo depth - 1

Hi Devyn,

...

>  static void hisi_i2c_xfer_msg(struct hisi_i2c_controller *ctlr)  {
> -	int max_write = HISI_I2C_TX_FIFO_DEPTH;
> +	int max_write = HISI_I2C_TX_FIFO_DEPTH - HISI_I2C_TX_F_AE_THRESH;

this is one of the differences.

Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi