linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Asmaa Mnebhi <Asmaa@mellanox.com>
To: minyard@acm.org
Cc: Asmaa Mnebhi <Asmaa@mellanox.com>,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: [PATCH v2 0/1] *** Add support for IPMB driver ***
Date: Wed, 17 Apr 2019 15:59:18 -0400	[thread overview]
Message-ID: <cover.1555529640.git.Asmaa@mellanox.com> (raw)

Thank you for your feedback Corey. I have addressed your inlined comments.

I understand your suggestion for making this an I2C driver.
I can certainly make those changes once we hear back from the i2c mailing list.
My only concern is that the ipmb_write is responsible for
sending the response via SMBus, so it needs the total length of the message.
So we need to document that this driver requires that the user program
(it is attached) passes the msg length as the first byte in the message. 

Asmaa Mnebhi (1):
  Add support for IPMB driver

 drivers/char/ipmi/Kconfig        |   8 +
 drivers/char/ipmi/Makefile       |   1 +
 drivers/char/ipmi/ipmb_dev_int.c | 407 +++++++++++++++++++++++++++++++++++++++
 3 files changed, 416 insertions(+)
 create mode 100644 drivers/char/ipmi/ipmb_dev_int.c

-- 
2.1.2

             reply	other threads:[~2019-04-17 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 19:59 Asmaa Mnebhi [this message]
2019-04-17 19:59 ` [PATCH v2 1/1] Add support for IPMB driver Asmaa Mnebhi
2019-04-27 15:58   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1555529640.git.Asmaa@mellanox.com \
    --to=asmaa@mellanox.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).