From: Heiner Kallweit <hkallweit1@gmail.com>
To: Peter Rosin <peda@axentia.se>, Wolfram Sang <wsa@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] drivers/i2c/busses: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON
Date: Fri, 24 Nov 2023 11:09:53 +0100 [thread overview]
Message-ID: <d12be9e6-e136-45fc-9d0e-dd290ef25277@gmail.com> (raw)
In-Reply-To: <0cee5543-711d-3d6e-f416-18889badff18@axentia.se>
On 24.11.2023 00:10, Peter Rosin wrote:
> Hi!
>
> 2023-11-18 at 19:04, Heiner Kallweit wrote:
>> diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
>> index e01d75308..9076ae4d7 100644
>> --- a/drivers/i2c/busses/i2c-kempld.c
>> +++ b/drivers/i2c/busses/i2c-kempld.c
>> @@ -283,8 +283,8 @@ static const struct i2c_algorithm kempld_i2c_algorithm = {
>> static const struct i2c_adapter kempld_i2c_adapter = {
>> .owner = THIS_MODULE,
>> .name = "i2c-kempld",
>> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD |
>> - I2C_CLASS_DEPRECATED,
>> + .class = I2C_CLASS_HWMON |
>> + I2C_CLASS_DEPRECATED,
>
> The above is less than ideal...
>
> It should obviously be:
>
> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD |
> - I2C_CLASS_DEPRECATED,
> + .class = I2C_CLASS_HWMON | I2C_CLASS_DEPRECATED,
>
Sure. Thanks for the hint.
> Cheers,
> Peter
next prev parent reply other threads:[~2023-11-24 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 18:04 [PATCH 00/10] Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON Heiner Kallweit
2023-11-18 18:04 ` [PATCH 01/10] drivers/i2c/busses: " Heiner Kallweit
2023-11-23 20:57 ` Wolfram Sang
2023-11-23 21:58 ` Heiner Kallweit
2023-11-18 18:04 ` [PATCH 02/10] drivers/staging/greybus/i2c.c: " Heiner Kallweit
2023-11-23 12:47 ` Greg Kroah-Hartman
2023-11-18 18:04 ` [PATCH 03/10] drivers/i2c/busses/i2c-pasemi-pci.c: " Heiner Kallweit
2023-11-18 18:04 ` [PATCH 04/10] drivers/i2c/i2c-stub.c: " Heiner Kallweit
2023-11-18 18:04 ` [PATCH 05/10] drivers/i2c/busses: " Heiner Kallweit
2023-11-23 23:10 ` Peter Rosin
2023-11-24 10:09 ` Heiner Kallweit [this message]
2023-11-18 18:05 ` [PATCH 06/10] drivers/i2c/busses/i2c-gpio.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 07/10] drivers/i2c/busses/i2c-mlxcpld.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: " Heiner Kallweit
2023-11-23 20:55 ` Wolfram Sang
2023-11-24 10:15 ` Heiner Kallweit
2023-11-18 18:05 ` [PATCH 09/10] drivers/i2c/busses/scx200_acb.c: " Heiner Kallweit
2023-11-18 18:05 ` [PATCH 10/10] drivers/i2c/busses/i2c-ali1563.c: " Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d12be9e6-e136-45fc-9d0e-dd290ef25277@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox