From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH V4] i2c: designware: fix wrong Tx/Rx FIFO for ACPI Date: Tue, 13 Dec 2016 15:35:57 +0200 Message-ID: References: <1481623414-19220-1-git-send-email-tnhuynh@apm.com> <1481628337.7188.63.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1481628337.7188.63.camel@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org To: Andy Shevchenko , Tin Huynh , Mika Westerberg , Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Loc Ho , Thang Nguyen , Phong Vo , patches@apm.com List-Id: linux-i2c@vger.kernel.org On 12/13/2016 01:25 PM, Andy Shevchenko wrote: > On Tue, 2016-12-13 at 17:03 +0700, Tin Huynh wrote: >> ACPI always sets Tx/Rx FIFO to 32. This configuration will >> cause problem if the IP core supports a FIFO size of less than 32. >> The driver should read the FIFO size from the IP and select the >> smaller >> one of the two. >> >> Signed-off-by: Tin Huynh >> > > One comment below, after addressing it > > Reviewed-by: Andy Shevchenko > Feel free to add my Acked-by: Jarkko Nikula