* [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings
@ 2022-08-29 21:47 Lad Prabhakar
2022-08-30 7:09 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lad Prabhakar @ 2022-08-29 21:47 UTC (permalink / raw)
To: Chris Brandt, Rob Herring, Krzysztof Kozlowski, Wolfram Sang,
Geert Uytterhoeven
Cc: linux-i2c, devicetree, linux-renesas-soc, linux-kernel, Prabhakar,
Biju Das, Lad Prabhakar
With 'unevaluatedProperties' support implemented, there's a number of
warnings when running dtbs_check:
arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
The main problem is that bindings schema marks resets as a required
property for RZ/G2L (and alike) SoC's but resets property is not part
of schema. So to fix this just add a resets property with maxItems
set to 1.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index bb1f3c7e0e6a..2291a7cd619b 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -60,6 +60,9 @@ properties:
power-domains:
maxItems: 1
+ resets:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings
2022-08-29 21:47 [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings Lad Prabhakar
@ 2022-08-30 7:09 ` Geert Uytterhoeven
2022-08-30 9:24 ` Krzysztof Kozlowski
2022-08-30 10:10 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-08-30 7:09 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Chris Brandt, Rob Herring, Krzysztof Kozlowski, Wolfram Sang,
Geert Uytterhoeven, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux-Renesas, Linux Kernel Mailing List, Prabhakar, Biju Das
On Mon, Aug 29, 2022 at 11:47 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings
2022-08-29 21:47 [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-30 7:09 ` Geert Uytterhoeven
@ 2022-08-30 9:24 ` Krzysztof Kozlowski
2022-08-30 10:10 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 9:24 UTC (permalink / raw)
To: Lad Prabhakar, Chris Brandt, Rob Herring, Krzysztof Kozlowski,
Wolfram Sang, Geert Uytterhoeven
Cc: linux-i2c, devicetree, linux-renesas-soc, linux-kernel, Prabhakar,
Biju Das
On 30/08/2022 00:47, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings
2022-08-29 21:47 [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-30 7:09 ` Geert Uytterhoeven
2022-08-30 9:24 ` Krzysztof Kozlowski
@ 2022-08-30 10:10 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-08-30 10:10 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Chris Brandt, Rob Herring, Krzysztof Kozlowski,
Geert Uytterhoeven, linux-i2c, devicetree, linux-renesas-soc,
linux-kernel, Prabhakar, Biju Das
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Mon, Aug 29, 2022 at 10:47:30PM +0100, Lad Prabhakar wrote:
> With 'unevaluatedProperties' support implemented, there's a number of
> warnings when running dtbs_check:
>
> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dtb: i2c@10058000: Unevaluated properties are not allowed ('resets' was unexpected)
> From schema: Documentation/devicetree/bindings/i2c/renesas,riic.yaml
>
> The main problem is that bindings schema marks resets as a required
> property for RZ/G2L (and alike) SoC's but resets property is not part
> of schema. So to fix this just add a resets property with maxItems
> set to 1.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-30 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-29 21:47 [PATCH] dt-bindings: i2c: renesas,riic: Fix 'unevaluatedProperties' warnings Lad Prabhakar
2022-08-30 7:09 ` Geert Uytterhoeven
2022-08-30 9:24 ` Krzysztof Kozlowski
2022-08-30 10:10 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).