From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78D8C43217 for ; Sat, 19 Nov 2022 12:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231482AbiKSM6D (ORCPT ); Sat, 19 Nov 2022 07:58:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231598AbiKSM6B (ORCPT ); Sat, 19 Nov 2022 07:58:01 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FFF89E086 for ; Sat, 19 Nov 2022 04:57:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668862626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4oyHKxSWWaJxvSt13X7gQ3W9bbef9cwNK4vJDf9Pqz8=; b=WJqfqjjhv/fnsLxlLSKcxXrpqzoGP1KM7RQ9rvrAR2rYHT7qIQpmGMjQ4rxh7U5KLYtj1m Zusr8NdH9awq6thfoTWdoU4rgi3MdoT0eYc5mqyJqMcEsd8l45Q9FML6/yyJCWnf8N3ki3 Gmm56kZyDP7MZflgQicrh3RYFl32JFo= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-UjGYqpDfOjmUSzONn3wjbw-1; Sat, 19 Nov 2022 07:57:05 -0500 X-MC-Unique: UjGYqpDfOjmUSzONn3wjbw-1 Received: by mail-ej1-f69.google.com with SMTP id nb1-20020a1709071c8100b007ae4083d6f5so4656778ejc.15 for ; Sat, 19 Nov 2022 04:57:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4oyHKxSWWaJxvSt13X7gQ3W9bbef9cwNK4vJDf9Pqz8=; b=OoWZoIs8OgsRNJN6CRCYxnYmloQC4Nbcqk1+tHYpRf2CdhRHDaDbLvPoefANl4TODz 9yCM7zrCsM87uSyALW30DoTSPAON+vELSfzw3TbYZWW6jPalfoephrG5EQnbJKpWY1gq 5TmyBjYmzbpnFoLjTvT8l7cnt+fHN0+5K5iSxGwEQoj62Vup/Xm/RszHU1pWdd4LLgPk cG6l7Muk4mRfni3yuEUYvy6g+VLCOKY1UOB3q7g0UmCRYCNgzOYiRYyFYDWhw2+rSScp t1VGPugFpmRRDrGyJIQejEsZ+2V4ehuQrOctXggZJpNeQC/cf5GdkF4vCPwio0agYGJ3 LWCQ== X-Gm-Message-State: ANoB5pmuB5jzNiofZlEKPFM4n7IIuxtuwsaFNjzRDkjqZBg2Uc9Tr0ZX buJxtpvt123kyVrG20cO8NdRT1EUJtaSf69qN64ibk71d5HwvpqDajBgkyaAKYKKEWIWK01/K0Z cKyhQnQz3e7ES4fJ0nE6M X-Received: by 2002:a17:906:c1d0:b0:7b4:64d3:e6f4 with SMTP id bw16-20020a170906c1d000b007b464d3e6f4mr1966153ejb.594.1668862624095; Sat, 19 Nov 2022 04:57:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf5kBIoMWHwUuIUW7BwTZr06498SZcEjQzU5PBmA2v2+rdXV+tr4u0SaFqxlCpSE9YmY7eUUCg== X-Received: by 2002:a17:906:c1d0:b0:7b4:64d3:e6f4 with SMTP id bw16-20020a170906c1d000b007b464d3e6f4mr1966143ejb.594.1668862623902; Sat, 19 Nov 2022 04:57:03 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id r9-20020a17090609c900b0078d4c72e2cesm2837826eje.44.2022.11.19.04.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 04:57:02 -0800 (PST) Message-ID: Date: Sat, 19 Nov 2022 13:57:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 056/606] iio: accel: mma8452: Convert to i2c's .probe_new() To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Jonathan Cameron , Haibo Chen , Martin Kepplinger Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-57-uwe@kleine-koenig.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20221118224540.619276-57-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Hi, On 11/18/22 23:36, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/iio/accel/mma8452.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 3ba28c2ff68a..f97fb68e3a71 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -1545,9 +1545,9 @@ static const struct of_device_id mma8452_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, mma8452_dt_ids); > > -static int mma8452_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int mma8452_probe(struct i2c_client *client) > { > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct mma8452_data *data; > struct iio_dev *indio_dev; > int ret; > @@ -1846,7 +1846,7 @@ static struct i2c_driver mma8452_driver = { > .of_match_table = mma8452_dt_ids, > .pm = &mma8452_pm_ops, > }, > - .probe = mma8452_probe, > + .probe_new = mma8452_probe, > .remove = mma8452_remove, > .id_table = mma8452_id, > };