Re: [PATCH v2 1/8] dt-bindings: qcom: geni-se: Add 'firmware-name' property for firmware loading

Viken Dadhaniya
2025-01-24T11:34:04Z

On 1/24/2025 4:30 PM, Krzysztof Kozlowski wrote:
> On 24/01/2025 11:53, Viken Dadhaniya wrote:
>> Document the 'firmware-name' property in the device tree bindings to
>> support loading SE (Serial Engine) firmware from the protocol driver,
>> allowing for more flexible firmware management.
>>
>> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> ---
>> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> index 7b031ef09669..3e029d4d6f58 100644
>> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> @@ -54,6 +54,10 @@ properties:
>>
>> dma-coherent: true
>>
>> + firmware-name:
>> + $ref: /schemas/types.yaml#/definitions/string
>
>
> You work on outdated tree. Just look how other bindings are doing this.
> maxItems instead.
>
>
> Best regards,
> Krzysztof
>

Sure, Will update in next patch.

Thanks
Viken