From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFA0C0015E for ; Mon, 7 Aug 2023 02:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229710AbjHGCNk (ORCPT ); Sun, 6 Aug 2023 22:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjHGCNj (ORCPT ); Sun, 6 Aug 2023 22:13:39 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C68489F; Sun, 6 Aug 2023 19:13:38 -0700 (PDT) Received: from kwepemi500012.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RK0Cs242Vz1Z1Td; Mon, 7 Aug 2023 10:10:49 +0800 (CST) Received: from [10.67.110.108] (10.67.110.108) by kwepemi500012.china.huawei.com (7.221.188.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 10:13:36 +0800 Message-ID: Date: Mon, 7 Aug 2023 10:13:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2 0/9] Use dev_err_probe in i2c probe function To: Andi Shyti CC: , , , , , , , , , , , , , , , , , , , , , References: <20230802095737.3957587-1-liaochang1@huawei.com> <20230804221953.abmpboxdzy2upswe@intel.intel> From: "Liao, Chang" In-Reply-To: <20230804221953.abmpboxdzy2upswe@intel.intel> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.110.108] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500012.china.huawei.com (7.221.188.12) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org 在 2023/8/5 6:19, Andi Shyti 写道: > Hi Liao, > > On Wed, Aug 02, 2023 at 05:57:28PM +0800, Liao Chang wrote: >> Use the dev_err_probe function instead of dev_err in the probe function >> so that the printed messge includes the return value and also handles >> -EPROBE_DEFER nicely. > > first of all thanks for this cleanup which is very much > appreciated! > > I need to ask you to add the version to all the patches, not just > patch 0/9. It's trivial if you do "git format-patch -v 2...". Hi Andi, Trully sorry for the misleading, I will add the version to all the patches and send them out in next revision. Thanks for taking the time to review these patches. > > Thanks, > Andi -- BR Liao, Chang