From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65ED949B5C3 for ; Fri, 9 Oct 2026 10:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540205; cv=none; b=Y5PvKXhgKCtWiLA7YAQ5oKIpzVg9TQ+EGEsDi5zBG0meqm2lOHaTIsvVr+JGXoEoW84uu2cqUkjbEYiMUi5lbxrqQuHaKwDu74fa9MZZeFV8ZAwKHNLkV5bEPfZ5iKsp0H6accVMA7PZUOdsPw+SbexqGzLdY66m7IrL7bLefS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791540205; c=relaxed/simple; bh=KPAFyUw7nX/MpchqdZD/H9rJtTKOPIWkCTHK0liR+yE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m1LQyOIuSvXg5Bu3rw2dup9x9at7TI6z26nKc+B8tYl1rUwPbQYNZu30S9fczsINehyPTzUSiFSSEJujvfg9C+Pxcdgbs49fEgTRFpZotiwAy5ZtO9N4u8XRe7gC7NsnSV8+8QoXip/fHNvudF+7H9j0SaG7khulTRyMsfpFMrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=X+gJx+86; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="X+gJx+86" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49d0da752ffso56674055e9.3 for ; Fri, 09 Oct 2026 03:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1791540200; x=1792145000; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qPWJMeDyVSRIeJtDK0w7ULZSIZyQfconBMNDwO4cVgs=; b=X+gJx+86UR0wiJapCi7qYJfEeUAnWJx723oaYX2UjY8JGe38SiECpw65yTvFfitb2y drJYwVo25AZuQFWgsiQ8ca/vcIL9sQoBvMuhhQKzp9NmI99vthM0fSTEjRVc8/Vu9d9L L3INcs9Fd/MZXkrDMjUetbfWkSUm5LHPQuNsSjqca/BvaJW7yY4UWMJhc9zWeITJyaxp Ni446nAlJuF6+1buV0EmsonK9YDbSpYgW+RUYIVTtq/WtjV3Xk2ua/y6vG+Z9QJqw/Bt NTb3gNqQUChi27ieP0sKxK6XHRf4qno/OVrwOUg7IiWrLs2Z0sTIc7vZt7glZM/EG/vf diuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791540200; x=1792145000; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qPWJMeDyVSRIeJtDK0w7ULZSIZyQfconBMNDwO4cVgs=; b=eFfDStuqIZjwN6M3Ss8pyjp8PXR9AifKKsYSPEJcN5JmmuWtF6tZYjrGQ53PE5OJxy WDscT1HHLkI8JAGxvwtEd9qYwYTCbR9lg6lJnp9zruo0RpEQB18KyKJrTciVg5U0Hlru YY8fLLkviyCVwuV/TCWR42vVT+bYVBT1rV8Z1xJpRQSxI+GiPMSrT/OBJQM0N9ocI4K2 rOAhS6Obt6cH/XsxbPzDf86yEy2bU8wDr0GDaXfRxvbm5ZjdQonyWkbip4p7136+PMBw DjSlRqHs+go3sDD7gIlxzWQOVDEBliI62JbpKI2sfqt5ntOBrQn1uBZzRnoBSpg7savS Y2NA== X-Forwarded-Encrypted: i=1; AKwUvBw38X7jF+PyEE9rcHeF2ZoHB9TQR+qwBTZmB0C7+TN2nvqrHsMF9I/1NcxO7IBMqXi/XjqfWumgvKY=@vger.kernel.org X-Gm-Message-State: AFuF++k8+/f1HrR3GA/fH4oOetwM45fRlaNTX29vsGdBw00r9qxpsJhf MvrIOzWqUIJM1EvtK5c+CQZmzWabJW81w+7BJ8K+A1hkLLJS2zWdc2Jtk9OsiHRM4X0= X-Gm-Gg: AYBFou02C+tVeBDFr0Q+v98LT8FSIW7Tz8unmBXxZhxOzp9DJayTZZlx30AOw+IzNoZ piZ3VSGcT6LRa7I6huSNUZkEOJphLYObPzjrFSOdt8OQ7C4+Vo+MIAX0CrASxl41S5bhjkeyop7 Gjq9xSvRwaQVnBbZ7ME942G4M0LrVAx+oXmgKSs/x7a4CLNJG05zYGuDT7BwOQ9XH0zgJMTYD4k Yn7T+TDXlAXuGSHlBwiAZISR9mb8n2z3hQlPheqeUO8c1Akqxduc72kUpFWQopJryayTZcn2h1g l+283PDAhaBtXNtLeXwVVN+opuq7T7HS9EuinIMQLibypA99lYmywIC9R0HEyPStr31NZ1oDsZx cNfjAQnuqaIyFEyCnBhZqsr37sEukW6dz81qaTB97MIXHQ5FNtbYJ609ZXILk1Jqw1yDJkuQ/ia Sxka/3djgg3LCN5fFvw++BnpuAJFEjU8XwSNM/PeLJuQcXtAfkl4SjPpGSenAJmvaM7PCbhqm0R P5v2dNFNQS3 X-Received: by 2002:a05:600c:4ecb:b0:4a1:76c9:5408 with SMTP id 5b1f17b1804b1-4a18e4a510emr26609695e9.11.1791540198883; Fri, 09 Oct 2026 03:03:18 -0700 (PDT) Received: from [100.64.0.1] ([147.161.130.187]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18eb4485dsm68317565e9.2.2026.10.09.03.03.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2026 03:03:18 -0700 (PDT) Message-ID: Date: Fri, 9 Oct 2026 12:03:16 +0200 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 6/7] riscv: dts: eswin: add I2C controller support To: Pinkesh Vaghela Cc: Yulin Lu , Darshan Prajapati , Pritesh Patel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Andi Shyti , Mika Westerberg , "linux-i2c@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , Min Lin References: <20260814070007.1662455-1-pinkesh.vaghela@einfochips.com> <20260814070007.1662455-7-pinkesh.vaghela@einfochips.com> Content-Language: en-US From: Samuel Holland In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Pinkesh, On 2026-09-30 3:06 PM, Pinkesh Vaghela wrote: >>> + aon_i2c0: i2c@51830000 { >> >> Please keep nodes sorted (the aon block controllers go below GPIO, etc.). > > As per DTS coding style document [1], "Order of Nodes" states that > "Nodes on any bus, thus using unit addresses for children, shall be ordered by unit > address in ascending order. Alternatively for some subarchitectures, nodes of the > same type can be grouped together, e.g. all I2C controllers one after another even > if this breaks unit address ordering." > > Do you still prefer to change order? Yes. I believe the alternative option is allowed because a few platforms were already doing things that way, to avoid forcing them to change. However, for a new platform, it is best to follow the recommended pattern; simple numerical order is easier to understand, verify, and automate with tooling (which is on the way). Regards, Samuel > [1] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html > > Regards, > Pinkesh > >> >> Regards, >> Samuel >> >>> + compatible = "eswin,eic7700-i2c", "snps,designware-i2c"; >>> + reg = <0x0 0x51830000 0x0 0x8000>; >>> + interrupts = <290>; >>> + clocks = <&clk EIC7700_CLK_GATE_AON_I2C0_PCLK>; >>> + clock-names = "ref"; >>> + clock-frequency = <100000>; >>> + resets = <&reset EIC7700_RESET_ANO0>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "disabled"; >>> + }; >>> + >>> + aon_i2c1: i2c@51838000 { >>> + compatible = "eswin,eic7700-i2c", "snps,designware-i2c"; >>> + reg = <0x0 0x51838000 0x0 0x8000>; >>> + interrupts = <291>; >>> + clocks = <&clk EIC7700_CLK_GATE_AON_I2C1_PCLK>; >>> + clock-names = "ref"; >>> + clock-frequency = <100000>; >>> + resets = <&reset EIC7700_RESET_ANO1>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + status = "disabled"; >>> + }; >>> + >>> gpio@51600000 { >>> compatible = "snps,dw-apb-gpio"; >>> reg = <0x0 0x51600000 0x0 0x80>; >