From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D090221B19F; Fri, 24 Jan 2025 12:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737721362; cv=none; b=bLRMp+opkjm66xCDAPhEMw2vLXEiVBAawMSd8TbBJInv/mWbPBGk1L2b956c/IHNucabHblAOuTltGEQQftLtS1OzSFFSmZ9cTOgkMBLafDRi1oD9+Dt/X8qepLqL+fH7olRzQHDJ+buzRhw6ox09qntpSoXvorKH72q1labZvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737721362; c=relaxed/simple; bh=3070F8k4oMWQWeOnpNtigrjl5rR5EysvkU4DqoFDD3M=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=m0EkHXgL0hNHajiCU5ct17k9Xp8mdZxQMjU2tBsV5wZUFMpB+LcwlChjXQH8bdfGWvVZ+gV1Rs7uQs6ezx2KGLr2Yke2hj6AjfmtMKhcRemOgOuJNbEVAPJkf+q2yS2KRgbow1/AHnrPsPLDicb12Q1/D/59XYIcEgG23l/TYzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=kBiFRCYN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="kBiFRCYN" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50OBrbji008568; Fri, 24 Jan 2025 12:22:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mF0lG9JJJ/RmBA+CiPEn9CWgwPAiC83uRRhPGJMn/is=; b=kBiFRCYNuKVS7Yg7 5V5Iqg9weLeA32R0baeqpyrue0oK5cgvgBFBDgo7ffmQucsXN+Yz09+qDLl4wBda LJ3GimSwRRDsqavDKZQiXts31VTOEzsROR7G8Q1DeAAdDptTpRVnSynsp3yA6+qA tfWH68Qx6u6hyBzkjn4VauQST/M5eBVAy4p/bQkXITbF/wJEpdJ9HLWVHcbIoBe8 isx1iLXzRalSNaprZw2iYNaEhJ+CG7czOpSw2IJ8TetPmUx13aSqUbVjkBAREDA+ ElCd52DQWlt95wOPQbT5WpcXLsKDfg3oz0AtIILXbsJ3avYrsDKWOjZbP/4n7YuE v867kw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44cacr82au-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 12:22:35 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 50OCMYpO012957 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jan 2025 12:22:34 GMT Received: from [10.216.19.102] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 24 Jan 2025 04:22:28 -0800 Message-ID: Date: Fri, 24 Jan 2025 17:52:24 +0530 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] dt-bindings: i2c: qcom,i2c-geni: Add support for selecting data transfer mode To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , , References: <20250124105309.295769-1-quic_vdadhani@quicinc.com> <20250124105309.295769-3-quic_vdadhani@quicinc.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 97DMXRCQ8BgMIphNNQ6Lb3ZJdMOGO9vB X-Proofpoint-ORIG-GUID: 97DMXRCQ8BgMIphNNQ6Lb3ZJdMOGO9vB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-24_05,2025-01-23_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 impostorscore=0 phishscore=0 mlxscore=0 malwarescore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501240090 On 1/24/2025 4:48 PM, Dmitry Baryshkov wrote: > On Fri, Jan 24, 2025 at 04:23:03PM +0530, Viken Dadhaniya wrote: >> Data transfer mode is fixed by TrustZone (TZ), which currently restricts >> developers from modifying the transfer mode from the APPS side. >> >> Document the 'qcom,xfer-mode' properties to select the data transfer mode, >> either GPI DMA (Generic Packet Interface) or non-GPI mode (PIO/CPU DMA). >> >> I2C controller can operate in one of two modes based on the >> 'qcom,xfer-mode' property, and the firmware is loaded accordingly. > > Is it possible to load the firmware after it being loaded by TZ? Is it > possible to change the mode at runtime too? No, firmware can be loaded either from the TZ side or APPS side. In non-GPI mode, the transfer mode will change runtime between PIO and CPU DMA based on the data length. We need to update the device tree property(qcom,xfer-mode) to change the mode between non-GPI and GPI. > >> >> Co-developed-by: Mukesh Kumar Savaliya >> Signed-off-by: Mukesh Kumar Savaliya >> Signed-off-by: Viken Dadhaniya >> --- >> >> v1 -> v2: >> >> - Drop 'qcom,load-firmware' property and add 'firmware-name' property in >> qup common driver. >> - Update commit log. >> >> v1 Link: https://lore.kernel.org/linux-kernel/20241204150326.1470749-2-quic_vdadhani@quicinc.com/ >> --- >> --- >> .../devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> index 9f66a3bb1f80..68e4bf0c84d1 100644 >> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml >> @@ -66,6 +66,12 @@ properties: >> required-opps: >> maxItems: 1 >> >> + qcom,xfer-mode: >> + description: Set the value to 1 for non-GPI (FIFO/CPU DMA) mode and 3 for GPI DMA mode. >> + The default mode is FIFO. >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [1, 3] >> + >> required: >> - compatible >> - interrupts >> @@ -142,5 +148,6 @@ examples: >> interconnect-names = "qup-core", "qup-config", "qup-memory"; >> power-domains = <&rpmhpd SC7180_CX>; >> required-opps = <&rpmhpd_opp_low_svs>; >> + qcom,xfer-mode = <1>; > > What does <1> mean? Please provide corresponding defines. Do we need to add a string instead of a number, like include/dt-bindings/dma/qcom-gpi.h? > >> }; >> ... >> -- >> 2.34.1 >> >