From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiner Kallweit Subject: Re: [PATCH v4 03/10] i2c: meson: set clock divider in probe instead of setting it for each transfer Date: Fri, 24 Mar 2017 07:45:25 +0100 Message-ID: References: <1a2ecdc8-a326-a7a7-22ec-658fd147daf4@gmail.com> <20170323203156.jjsiu7hydebzh66l@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:33176 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbdCXGtV (ORCPT ); Fri, 24 Mar 2017 02:49:21 -0400 Received: by mail-wm0-f65.google.com with SMTP id n11so1340026wma.0 for ; Thu, 23 Mar 2017 23:49:20 -0700 (PDT) In-Reply-To: <20170323203156.jjsiu7hydebzh66l@ninjato> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Jerome Brunet , Kevin Hilman , "linux-i2c@vger.kernel.org" , linux-amlogic@lists.infradead.org Am 23.03.2017 um 21:31 schrieb Wolfram Sang: > On Tue, Mar 14, 2017 at 10:53:29PM +0100, Heiner Kallweit wrote: >> The bus frequency won't change, therefore we can set the clock divider >> in probe already and we don't have to set it for each transfer. > > This is true for some SoCs, but not for all. So, some proof we can > really do it like this would be nice in the commit message, e.g. "parent > clock is fixed anyhow" or something. > Here the bus frequency is fixed to what is set in DT. I'll extend the commit message. >> >> Signed-off-by: Heiner Kallweit