From: <Codrin.Ciubotariu@microchip.com>
To: <linux@armlinux.org.uk>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <wsa@kernel.org>,
<alpawi@amazon.com>
Subject: Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery
Date: Sun, 4 Oct 2020 09:52:34 +0000 [thread overview]
Message-ID: <df004cc9-ac2c-775c-f567-4767e5971a2c@microchip.com> (raw)
In-Reply-To: <20201004092455.GI1551@shell.armlinux.org.uk>
On 04.10.2020 12:24, Russell King - ARM Linux admin wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote:
>> Starting with
>> commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery")
>> GPIO bus recovery is supported by the I2C core, so we can remove the
>> driver implementation and use that one instead.
>>
>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>> ---
>>
>> This patch is not tested.
>>
>> Changes in v2:
>> - readded the pinctrl state change to default from the
>> unprepare_recovery callback;
>
> I don't think you've build tested this patch...
You're right, sorry about that. I used a wrong config... Will fix it
right away.
Best regards,
Codrin
>
>> diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
>> index 35ca2c02c9b9..006cc1d5931f 100644
>> --- a/drivers/i2c/busses/i2c-pxa.c
>> +++ b/drivers/i2c/busses/i2c-pxa.c
>> @@ -264,9 +264,6 @@ struct pxa_i2c {
>> u32 hs_mask;
>>
>> struct i2c_bus_recovery_info recovery;
>> - struct pinctrl *pinctrl;
>> - struct pinctrl_state *pinctrl_default;
>> - struct pinctrl_state *pinctrl_recovery;
>
> i2c_pxa_unprepare_recovery() refers to pinctrl and pinctrl_default which
> you've retained in this version of the patch, but you've deleted the
> members from this structure - which will lead to a build error.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
>
prev parent reply other threads:[~2020-10-04 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 9:16 [PATCH v2] i2c: pxa: move to generic GPIO recovery Codrin Ciubotariu
2020-10-04 9:24 ` Russell King - ARM Linux admin
2020-10-04 9:52 ` Codrin.Ciubotariu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df004cc9-ac2c-775c-f567-4767e5971a2c@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=alpawi@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).