From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Wenmeng Liu <quic_wenmliu@quicinc.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vikram Sharma <quic_vikramsa@quicinc.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8775p: Add CCI definitions
Date: Wed, 14 May 2025 06:37:38 +0100 [thread overview]
Message-ID: <e1c4cb6b-2445-47ab-a908-af3e4833385d@linaro.org> (raw)
In-Reply-To: <20250514-rb8_camera-v1-3-bf4a39e304e9@quicinc.com>
On 14/05/2025 03:40, Wenmeng Liu wrote:
> Qualcomm SA8775P SoC contains 4 Camera Control Interface controllers.
>
> Signed-off-by: Wenmeng Liu <quic_wenmliu@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 268 ++++++++++++++++++++++++++++++++++
> 1 file changed, 268 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 9a8f60db87b1afdf16cf55eb2e95f83eb45803a5..a867694b15b307344b72041e972bae6e7543a98f 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -3941,6 +3941,162 @@ videocc: clock-controller@abf0000 {
> #power-domain-cells = <1>;
> };
>
> + cci0: cci@ac13000 {
> + compatible = "qcom,sa8775p-cci", "qcom,msm8996-cci";
> + #address-cells = <1>;
> + #size-cells = <0>;
The ordering here is not consistent with upstream. Please stick to that
for your examples:
arch/arm64/boot/dts/qcom/sc8280xp.dtsi
Documentation/devicetree/bindings/dts-coding-style.rst
---
bod
next prev parent reply other threads:[~2025-05-14 5:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 2:40 [PATCH 0/4] Add dt-bindings and dtsi changes for CAMSS on IQ-9075-evk Wenmeng Liu
2025-05-14 2:40 ` [PATCH 1/4] dt-bindings: media: camss: Add supplies for qcom,sa8775p-camss binding Wenmeng Liu
2025-05-14 5:28 ` Bryan O'Donoghue
2025-05-14 2:40 ` [PATCH 2/4] dt-bindings: media: Add sa8775p cci dt binding Wenmeng Liu
2025-05-14 5:28 ` Bryan O'Donoghue
2025-05-19 15:10 ` Wolfram Sang
2025-05-14 2:40 ` [PATCH 3/4] arm64: dts: qcom: sa8775p: Add CCI definitions Wenmeng Liu
2025-05-14 5:37 ` Bryan O'Donoghue [this message]
2025-05-20 16:08 ` Konrad Dybcio
2025-05-14 2:40 ` [PATCH 4/4] arm64: dts: qcom: qcs9075-rb8: Enable IMX577 camera sensor Wenmeng Liu
2025-05-14 5:43 ` Bryan O'Donoghue
2025-05-20 16:17 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1c4cb6b-2445-47ab-a908-af3e4833385d@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=quic_vikramsa@quicinc.com \
--cc=quic_wenmliu@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox